fix(trial): resolve hosted control routes before execution - #120
Open
stormstarlight wants to merge 1 commit into
Open
fix(trial): resolve hosted control routes before execution#120stormstarlight wants to merge 1 commit into
stormstarlight wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hosted Copilot trial is a custom provider catalog, but
backend_uses_openai_catalog()still reports it as the personal OpenAI catalog. Automatic Manager classification, bounded DAG,/planand rewrite routes can therefore resolve built-in catalog defaults instead ofCLIENT_MODEL.The later
trial_model_options()CLI override does not make the earlier resolved model, admission/accounting metadata and validation consistent. This also conflicts with integrations that validate the model before spawning a worker.Change
Exclude hosted trial from Copilot's personal catalog test, using the existing env/persisted trial resolver. The automatic control routes then reuse the existing role-level trial selector. Personal Copilot and Codex provider handling are unchanged. No saved model settings, gateway policy, or actual upstream model identity is changed or inferred.
Validation
pytest tests/core/test_trial_control_routes.py tests/core/test_cheap_route_models.py tests/test_config_help.py: 76 passed on Windows/Python 3.11.git diff --checkpassed.This is intentionally independent of draft #119. Windows plugin process/installation fixes are being kept in a separate dependent PR; no local preview UI redesign, cost-policy change, generated installer or credential is included here.