fix(runner): classify failures from current terminal diagnostics - #109
Draft
Haloukaidi wants to merge 1 commit into
Draft
Haloukaidi wants to merge 1 commit into
Haloukaidi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovered stderr can still turn a current 503/SSE failure into an authentication failure after #102. It can also affect retry ownership and pre-provider refusal accounting, while an earlier recoverable error can hide the stop reason that actually terminated the process.
Select the current terminal diagnostic once and share it across result translation, auth detection/replay, and refusal checks. Preserve raw stderr separately. Startup fallback uses the latest diagnostic only for a generic receipt without model progress; a sticky progress flag survives bounded event capture. An actual watchdog stop replaces an earlier recoverable error. Codex terminal errors also replace prior diagnostics when their message is empty, while the execution-host failure handling added in #104 remains authoritative.
The existing Manager wall-clock timeout behavior is retained for a final explicit reconnect/429 notice: it is a narrow cooldown scheduling hint, not an auth diagnostic or a replacement for an operator-stop receipt.
Validation on Windows / Python 3.13:
git diff --checkpassed.Draft for review of the shared diagnostic contract and remote CI. Refs #102 and #104; their already-fixed cases remain covered.