Skip to content

Fix plotting issues - #89

Merged
AntoineGautier merged 14 commits into
masterfrom
issue88_fixPlot
Sep 26, 2025
Merged

Fix plotting issues#89
AntoineGautier merged 14 commits into
masterfrom
issue88_fixPlot

Conversation

@AntoineGautier

@AntoineGautier AntoineGautier commented May 15, 2025

Copy link
Copy Markdown
Collaborator

This closes #88.

⚠️ Non-backward compatible: The new implementation uses ThreadingHTTPServer which breaks support for Python 2.

TODO: (all addressed via #94)

  • Clean code and documentation to remove anything related to Python 2
  • Make new major version and mention breaking change
  • Add Ubuntu 24.04 to the list of tested OS

@AntoineGautier

Copy link
Copy Markdown
Collaborator Author

@mwetter I've refactored the server launch using ThreadingHTTPServer. With this change, Python 2 is no longer supported. Do you think this is acceptable?

@mwetter mwetter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntoineGautier : Thanks for the changes.

The changes look good, but please add Ubuntu 24.04 to the list of tested OS.

Dropping Python 2 is fine.

@AntoineGautier
AntoineGautier force-pushed the master branch 4 times, most recently from 5ac7d74 to 9498ad9 Compare September 25, 2025 08:45
@AntoineGautier
AntoineGautier merged commit 716962c into master Sep 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix plotting issues

2 participants