Skip to content

Import Pico from SCSS instead of CSS #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JayHuLBL merged 1 commit into from
Aug 19, 2026
Merged

Import Pico from SCSS instead of CSS #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/src/styles/application.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
@import url("https://fonts.googleapis.com/css2?family=Roboto:wght@300;400;500&display=swap");
/* npm modules */
@import "~flexboxgrid";
@import "~@picocss/pico/css/pico.css";
@import "~@picocss/pico/scss/pico";

@import "./vars";
// themeing pico
Expand Down
11 changes: 5 additions & 6 deletions client/src/styles/vars.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,11 @@
--footer-height: 5rem;
}

// normalize.css and pico.css both set `line-height` on the root element via
// zero-specificity `:where()` selectors, so whichever one is later in the
// compiled stylesheet wins. Production builds concatenate CSS modules in a
// different order than the dev server, which flips the winner and shrinks
// line-height app-wide. Pin it explicitly here (real specificity) so it
// can't lose to either vendor reset regardless of build order.
// normalize.css and Pico both set `line-height` on the root element via
// zero-specificity `:where()` selectors, so whichever ends up later in the
// compiled stylesheet wins the cascade — order that isn't guaranteed to match
// source order once webpack concatenates separate CSS modules. Pin it here
// with real specificity so it can't lose regardless of module order.
html {
line-height: var(--line-height);
}