Embedding Advanced Course Image-5 #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Safiya <147792763+safiya2610@users.noreply.github.com>
Signed-off-by: Safiya <147792763+safiya2610@users.noreply.github.com>
Contributor
|
@safiya2610 attach issue number and remove PNG image also |
Signed-off-by: Safiya <147792763+safiya2610@users.noreply.github.com>
Contributor
Author
|
@saurabhraghuvanshii can you please review the PR. |
saurabhraghuvanshii
requested changes
Dec 15, 2025
Comment on lines
103
to
106
| {{< meshery-design-embed | ||
| id="embedded-design-1df080e7-da8e-4a48-8557-c21fbb117a1d" | ||
| src="file.js" | ||
| >}} |
Contributor
There was a problem hiding this comment.
please keep this in one line
Contributor
Author
There was a problem hiding this comment.
I update it now you can review it, if any other update needed please tell. @saurabhraghuvanshii
Updated the meshery design embed syntax in the load balancing documentation. Signed-off-by: Safiya <147792763+safiya2610@users.noreply.github.com>
saurabhraghuvanshii
requested changes
Dec 15, 2025
...6-937c-47ea-ab43-5716e3bcab2e/exoscale-101/advanced-course/networks/load-balancing/_index.md
Outdated
Show resolved
Hide resolved
…oscale-101/advanced-course/networks/load-balancing/_index.md Signed-off-by: Saurabh Singh <saurabhsraghuvanshi@gmail.com>
Contributor
|
@safiya2610 rename file as same as PNG name |
Signed-off-by: Safiya <147792763+safiya2610@users.noreply.github.com>
Contributor
Author
|
@saurabhraghuvanshii I update the .js file name. |
saurabhraghuvanshii
requested changes
Dec 15, 2025
...6-937c-47ea-ab43-5716e3bcab2e/exoscale-101/advanced-course/networks/load-balancing/_index.md
Outdated
Show resolved
Hide resolved
…oscale-101/advanced-course/networks/load-balancing/_index.md Signed-off-by: Saurabh Singh <saurabhsraghuvanshi@gmail.com>
saurabhraghuvanshii
approved these changes
Dec 15, 2025
Contributor
|
@safiya2610 Thanks for your hard works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done Embedding Advanced Course Image-5 #159
Screenshot:
Here's the PR for this issue.
@saurabhraghuvanshii Please review it.