fix(blocks): replace raw buttons with DropdownMenuItem in DataTableAdvanced export#435
Merged
fix(blocks): replace raw buttons with DropdownMenuItem in DataTableAdvanced export#435
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- DropdownMenuItem was used at lines 381-386 but not imported - Resolves TS2552 TypeScript errors in DataTableAdvanced.tsx
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<button>elements in the export dropdown with<DropdownMenuItem>from the design systemChanges
src/blocks/data/DataTableAdvanced/DataTableAdvanced.tsx: UseDropdownMenuItemfor CSV and JSON export items instead of manually-styled raw buttonsWhy
The export dropdown was the only place in the file using raw
<button>elements with hand-replicated Radix/DS styles. All other interactive items in the file use proper DS components. This aligns with the DS convention of composing over Radix primitives.Verification