Repository navigation
Update to upstream v0.10.8 with calendar time format, spellcheck, and Save as .eml - #8
Merged
Merged
Conversation
## Summary
Omarchy's `SUPER+SHIFT+E` opens HEY's web app directly (`{ webapp =
"https://app.hey.com" }` in `default/hypr/bindings/applications.lua`)
and reads no default, so claiming `mailto:` alone leaves the key opening
HEY. This follows omanta's approach for `SUPER+SHIFT+F`:
- `scripts/default-mail.sh on <plugin-dir>` registers `omamail.desktop`
as the `x-scheme-handler/mailto` default and appends a managed block to
`~/.config/hypr/bindings.lua` that unbinds and rebinds `SUPER+SHIFT+E`
(open Omamail) and `SUPER+SHIFT+ALT+E` (new message,
`{"compose":true}`), then reloads Hyprland. Omarchy's own files are
never touched.
- `off` removes the block and leaves the file byte-identical; `status`
prints `default` or `not-default`.
- Settings gains a **Default mail client** section with **Set as
default** / **Undo**. `Service.qml` runs the script from the plugin
directory, so the feature is QML plus a script and needs no backend
release — there is no Rust or `backend-api.json` change. The status is
read when the service starts, when the page's `service` binds and
whenever the page comes into view, so a change made outside the window
is reflected. The section is shown only where the platform declares
`mailto`.
## Screenshots
Pending: before/after of Settings → Default mail client.
## Release Notes
- Add Settings → Default mail client, which makes Omamail open `mailto:`
links, `SUPER+SHIFT+E` and `SUPER+SHIFT+ALT+E`, with an Undo that
restores Omarchy's own email binding.
## Verification
- `tests/test_default_mail.sh` (added to `make test-shell`): on,
idempotent second on, status, byte-identical off, unknown action refused
— in a throwaway config/data home.
- Tested by hand in the linked plugin: Set as default, `SUPER+SHIFT+E` /
`SUPER+SHIFT+ALT+E`, Undo.
- `make test-js test-shell`, `make qml-check`, `omarchy plugin validate
.`, `git diff --check` pass.
- `make test-qml`: 8 `KeyboardReaderNavigation` failures, identical on
clean `main`.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
## A more complete calendar in Omamail This PR redesigns the calendar: clearer views, easier navigation, better event editing, and useful reminders. Google Calendar is the first provider with the deeper native integration in this work, including calendar discovery, attendance updates and event management. The redesigned views and navigation apply to the calendar as a whole. New drag/resize writes and desktop reminders are Google-only; other providers retain their existing, more limited create/edit/delete behavior. Google-specific features are called out below. ## 1. A clearer month view Multi-day events now form one continuous bar, with continuation marks when they cross a week boundary. Overlapping trips and all-day events get separate rows. The month uses five or six weeks as needed, with lighter grid lines, a clearer today marker and more room for events. Narrow Month rows put the event title before the time, so a short cell still tells you what is happening. Busy-day previews show the event count and cap their height, with a visible scrollbar for longer lists. <details> <summary>Before/after: narrow Month titles and a long busy-day preview</summary> **Narrow Month — title first instead of a time taking most of the row.**  **Busy-day preview — bounded height, event count and scrolling.**  </details> The same synthetic month is shown in both images. Look at **Lakeside holiday**, **Design sprint** and **Design conference**: repeated daily blocks become readable spans. | Before | After | | --- | --- | |  |  | ### See everything on a busy day Hover a day with **“+ more…”** to see its complete event list. The day stays highlighted, entries can be opened directly, and longer lists scroll. You can inspect a busy day while keeping the rest of the month in view. Here, Friday has eight events across three calendars. The after image shows all eight, alongside the multi-day bars and redesigned month layout. | Before: hovering leaves the extra events hidden | After: a full-day preview opens | | --- | --- | |  |  | ## 2. Better Day and Week views - **A permanent all-day lane.** Click or drag in it to create an all-day event, even when the lane is empty. - **Continuous bars at the top.** Multi-day all-day events and timed events lasting at least a full local day sit above the hourly grid. Timed events keep their original start/end times; this is a display change. - **A clear distinction for timed spans.** Top-lane timed events say “Timed”; the current-time line stays behind event cards so it cannot strike through a meeting title. - **Readable overlaps.** Simultaneous meetings use separate columns and can be selected independently. - **All 24 hours are reachable.** Day and Week open around the morning and scroll from midnight to midnight. - **Clearer interaction.** Drag to create a time range. On Google calendars, move an event or resize either edge; a preview shows the change and failed saves restore the previous position. Other providers change event times through their existing editor. This comparison combines a long timed conference, a two-day workshop, a birthday, overlapping meetings and the current-time indicator. | Before | After | | --- | --- | |  |  | <details> <summary>Before/after: an empty all-day lane is still useful</summary> The same week with the top-lane events removed. The new lane remains available for click/drag creation. | Before | After | | --- | --- | |  |  | </details> ### Navigation that takes less space <details> <summary>Before/after: timed-span labels and a readable current meeting</summary>  </details> Day, Week, Month and Agenda share one dropdown, with their keyboard shortcuts shown beside them. Previous/next arrows surround the date, clicking the date opens a picker, and Today sits alongside it. The separate Create event button is replaced by direct calendar interaction and the existing keyboard shortcut. Agenda lists upcoming and ongoing events. Finished events drop out automatically. <details> <summary>Screenshots: Day, Agenda and the date picker</summary> These are new views/states; the Week comparison above shows the previous calendar experience. **Day**  **Agenda**  **Date picker**  </details> ## 3. A more capable event editor The editor brings the calendar, dates, times and event options together: - Choose the destination calendar, grouped by account. - Set separate start/end dates and switch between timed and all-day events. - Keep a clearly labelled Description directly below the title. - Suggest guests by name or address from the same known email contacts as the mail composer. Choose with a click or Up/Down and Enter; already-added addresses are excluded. - Edit the location, description, guests, time zone, availability, privacy and reminders where supported. - Add Google Meet and edit supported repeating-event rules. Advanced recurrence rules are preserved. - Press **Enter** to save and close. Invalid ranges show an error and prevent saving; a failed save keeps the form open. - Keep Save, Cancel and save errors in a fixed footer, even when the form scrolls. Keyboard-focused fields and guest suggestions scroll into view. - See persistent field labels, an explicit local-time indicator and reminder units. Time zone, availability and visibility live under **More options**. | Before | After | | --- | --- | |  |  | ### A compact form with visible feedback Description sits directly below Title with a persistent label. Typing a guest's name or email shows the same contact suggestions as composing mail. Enter chooses a suggestion while the list is open; Escape dismisses it without closing the event. Choosing a guest inserts only the email address and never submits the event. **Before/after: persistent labels, simpler default form and fixed action footer.**  **Before/after: a failed save in the same 660 × 900 window.** The error was below the scrolling viewport; it is now visible beside the save actions without manual scrolling.  <details> <summary>More editor comparisons: guest suggestions, reminder units and dark theme</summary>    </details> ## 4. Google integration that updates the actual calendar This goes beyond displaying Google events: | Action | What Omamail now does | | --- | --- | | **Connect calendars** | Finds the account's calendars, including shared and hidden entries. Lets you choose which to show and respects read-only access. | | **Answer an invitation in mail** | Yes / Maybe / No updates your own attendance in Google Calendar, then reads the event back to confirm the result. The native RSVP path does not send a second reply email. | | **Reopen an invitation or event** | Refreshes attendance and guest details, so the displayed answers can follow changes made elsewhere. | | **Edit or move an event** | Saves changes to the selected Google calendar. Supports moving eligible organizer-owned events between calendars in the same account. | | **Change an event with guests** | Offers a choice to notify guests or save without sending an update. Deletion has the same notification choice. | | **Work with a repeating event** | Loads the parent when editing the whole series and preserves existing recurrence exceptions. | | **Undo a supported change** | Checks the event revision before writing, to avoid overwriting a newer change. | | **Open meeting details** | Shows guest response states and the meeting link, with a copy action. | If an invitation cannot be matched to Google Calendar, or the connected backend is API 5, Omamail offers **Open Calendar** and clearly labelled **email-only** responses. An email-only reply does not mark Calendar attendance as confirmed. Gmail-generated travel events also explain their editing restrictions instead of offering unsupported time changes. <details> <summary>Before/after: Gmail invitations on the pinned API-5 backend</summary> The API-5 backend cannot execute native attendance updates. The invitation now offers explicit email-only responses instead of native choices that fail. These synthetic production-component captures use identical 900 × 600 dimensions, Solarized Light and scale 1; baseline `76c4e3a`. | Before | After | | --- | --- | |  |  | </details> The fallback shows one clear set of response choices. Event details put **Join meeting** and **Edit** near the title, followed by the description and guests. One **Delete...** control reveals the notification/series choices before the existing confirmation dialog. <details> <summary>Before/after: meeting details, delete choices and email-only invitation fallback</summary>    </details> <details> <summary>Screenshot: guest responses and meeting details</summary>  This synthetic capture illustrates the UI. It is not evidence of a live Google RSVP round trip; testing and remaining checks are listed below. </details> ### Other providers keep their limited behavior Microsoft/Outlook, iCloud and generic CalDAV keep the shared redesigned views and their existing basic event operations, with read-only and recurring-CalDAV restrictions preserved. Deep native attendance, transfers and advanced Google options remain Google-specific. New drag/resize writes and desktop reminders are explicitly restricted to Google, including polling and candidate generation: previously saved non-Google reminder settings cannot enable them. Microsoft creation omits the unsupported Repeat control and ignores stale repeat state after switching calendars. This is a compatibility boundary, not an expansion of the other provider adapters. Inherited limitations remain, including Outlook's preview-based description editing and incomplete attendee-status normalization; the new gestures no longer expose that editing path. <details> <summary>Before/after: limited Microsoft editor and calendar settings</summary> Synthetic production-component captures at identical 1000 × 1100 dimensions, Solarized Light, font base 14 and scale 1; baseline `c50c3f1`. The Microsoft editor no longer offers repetition that saving would reject. Settings remove non-Google reminder controls, including the global reminder section when no Google calendar is connected. | Microsoft editor — before | Microsoft editor — after | | --- | --- | |  |  | | Microsoft settings — before | Microsoft settings — after | | --- | --- | |  |  | </details> ## 5. Clearer setup and reminders Settings now start with accounts and use **one calendar list** for visibility and reminder preferences. Each account has a dropdown for its default calendar for new events. Default-calendar and reminder settings can be saved for any available account, even when another mailbox is selected; event writes retain their mailbox scope. Google setup reuses the Gmail account and shared OAuth client, with specific actions to retry discovery, sign in again or enable the Calendar API. Google desktop reminders have a global on/off switch, per-calendar timing and a snooze duration. They run while Omamail is running, even with its window closed. Hiding a Google calendar does not turn off its reminders. Google event reminders respect events that explicitly have no reminders. Notifications request **Open, Snooze and Dismiss**, but some desktop notification cards expose only the default action. Delivered reminders therefore also appear in the calendar and matching event details, with visible **Snooze** and **Dismiss** buttons. Opening a notification no longer dismisses its reminder. Failed reminder actions leave the controls available with an error; successful actions remove the notice. Old notification callbacks cannot acknowledge a newer delivery in the same running instance. A private persistent ledger prevents duplicate claims across shell and standalone instances. Each due event retains its own details and independent actions: dismissing one cannot dismiss or cancel another event's snooze, including records from an older grouped ledger. Reaching the desktop notification-process limit does not remove events from the in-app inbox. The in-app action list is session-local; restoring that list across restarts and cross-instance action synchronization remain runtime verification gaps. <details> <summary>Before/after: two reminders due in the same poll</summary> The grouped response exposed only the first event and a count. Each event now has its own title, Open, Snooze and Dismiss controls. These synthetic production-component captures replay the old and new response shapes for the same events at identical 900 × 600 dimensions, Solarized Light and scale 1; baseline `76c4e3a`. | Before | After | | --- | --- | |  |  | </details> **Before/after: reminder actions in narrow event details.**  <details> <summary>Reminder actions in the calendar and a failed-action state</summary>  **After: failure keeps the reminder and its actions available.**  </details> | Before | After | | --- | --- | |  |  | <details> <summary>More setup screenshots: connected accounts, selection, recovery and narrow layouts</summary> These pairs show the final settings refinement compared with the earlier version of this calendar implementation. | State | Before refinement | After refinement | | --- | --- | --- | | One list for each account's calendars |  |  | | First-time setup |  |  | | Choose calendars |  |  | | Recover from a connection error |  |  | | Narrow settings |  |  | **Reminder timing:** Off, Use Google event reminders, or Custom timing.  </details> ## Testing and review status **Latest diagnostics repair (`63b6716`):** added the backend’s `calendar_organizer_mismatch` identifier to the exact diagnostics allowlist, fixing the portable-test failure on `d393151`. The full portable shell suite and full `make validate` pass locally on this head. Fresh CI is pending; earlier green runs do not establish the status of this commit. **Validation:** Full `make validate` passes for `3704706`: Rust, JavaScript, shell/source checks, QML suites, standalone UI tests, QML lint and plugin validation. Both the development API-6 contract and pinned 0.10.7/API-5 released contract pass. Regression tests first failed against the original implementation, then passed for API-5 email-only replies, settings for another account, all-day drag moves across spring/autumn DST, and independent simultaneous reminders. The reminder tests also cover legacy grouped records and retaining inbox entries when the desktop process limit is reached. Provider-limit, editor interaction, reminder retry/stale-callback and event-identity coverage remain included. All 85 synthetic audit after captures, four provider-limit images and four review-repair images were inspected. This follow-up has not been installed locally. Cross-platform CI for `3704706` is pending. Previous cross-platform CI passed all 14 checks, including both macOS jobs, Linux/Windows standalone apps and backends, native credential contracts, portable tests and published/unreleased backend gates. Results for the newly pushed head must be checked separately. The concurrency regression reproduced a first lock-file creation failure on macOS with OS error `ENOENT`, matching the documented Darwin `openat(O_CREAT)` create-or-open race ([upstream report](golang/go#81246)). The fix uses exclusive creation followed, only on `EEXIST`, by a non-creating open of the existing lock file. Both calls remain descriptor-relative and no-follow; ownership, link-count, private-mode and ACL validation still precede locking. Concurrent initialization, reminder claims and unsafe-existing-lock regressions now pass in macOS CI as well as locally. Focused tests cover multi-day layout, overlap selection, full-day scrolling and 23:00 event creation, drag/resize rollback, Enter-to-save, invalid dates, timed/all-day request conversion, discovery recovery, attendance handling and reminder behavior. One user-requested calendar transfer was also checked against Google with a follow-up read. **Ready for review; remaining verification:** broader live Google checks remain, especially attendance matching outside the primary calendar, recurrence exceptions, all-day conversion and partial-transfer/Undo behavior. Reminder restart, suspend, cross-instance actions and Do Not Disturb behavior also need more runtime coverage. Desktop notification delivery is currently Linux-specific. Synthetic invitation and reminder interaction screenshots are included above; these do not establish live provider or desktop lifecycle behavior. <details> <summary>Implementation and security notes for reviewers</summary> - Calendar sources, caches and selections retain account/calendar identity. Google discovery keeps access, time-zone, reminder and conferencing metadata; older backend versions are gated from unsupported features. - Native attendance writes validate the responding attendee, use event revision checks and confirm the result by reading it back. The current lookup starts with the primary calendar copy. - Reminder fetching is independent of the visible date range. A private, locked, atomically written ledger records claims, snoozes and dismissals. - Concurrent first-time lock creation avoids Darwin's create-or-open race. Regression coverage includes concurrent initialization and refusal of symlinks, hard links, non-private files and macOS ACL grants without modifying rejected entries. - API-6 methods and contract cases are included. The published backend pin and version/API handshake are preserved. - Scoped tests cover origin/TLS/redirect restrictions, identity refusal, unsafe reminder-storage paths and notification escaping/actions. The macOS fixture resolves the trusted temporary parent and sets private fixture permissions; production storage checks remain unchanged. **Security verdict: NOT VERIFIED for release.** The scoped checks pass, but the complete new Google integration and reminder lifecycle still need the runtime evidence described above before approval. </details> <details> <summary>About the screenshots</summary> All images are synthetic Qt component captures using production calendar components and standalone UI adapters, with synthetic accounts/events and Solarized Light colours. They are not private live-mail screenshots. PNGs are uploaded to GitHub attachments and are not committed. Each before/after pair uses the same events, dates, window dimensions, theme, font size and scale. Main Month/Week scenes are 1440 × 1000, font base 14, scale 1. Editor/settings and additional view captures are 1200 × 1000. Settings-refinement pairs are 1000 × 1200, or 660 × 1200 for the narrow view. The main baseline is the pre-workspace calendar at `d583ab6`; settings-refinement pairs use `976c97a`. Before/after hover captures place the pointer over the same busy date. Week captures show each version's initial presentation of the same date range; the redesign's morning scroll position and long-event placement are intentional differences. The labelled side-by-side audit comparisons use `612a92a` as their baseline. Each half retains the same dimensions, fixture state, theme and scale: 1200 × 1100 for the editor, 660 × 900 for save failure and narrow details, 660 × 1000 for narrow Month, 1440 × 1000 for Week, and 900 × 700 for the invitation fallback. Dark editor and reminder/overflow comparisons use 1200 × 1000. The evidence includes 85 after-state captures and matched baselines; images were reviewed at contact-sheet and full resolution. No real event or RSVP mutation was made for this audit. </details> ## Release Notes - Redesign the calendar with clearer Month and Week layouts, Day and Agenda views, simpler navigation and full-day scrolling. - Show continuous multi-day events, a permanent all-day lane and complete busy-day hover previews. - Improve event creation and editing with multi-date ranges, richer options and Enter-to-save validation; enable drag/resize changes for Google events. - Suggest calendar guests from known email contacts and place a clearly labelled description below the event title. - Keep event save controls and errors visible, label reminder units, and simplify meeting details and invitation fallback choices. - Add deeper Google Calendar integration for calendar selection, event management, attendance updates and guest response details. - Simplify calendar settings and add Google desktop reminders with snooze and dismiss actions. - Preserve other calendar providers' existing limited event operations without offering Google-only gestures or reminders. - Make delivered reminders actionable inside the calendar even when the desktop notification omits action buttons. - Keep Gmail email-only invitation replies available on the pinned backend, save calendar preferences across accounts, and preserve all-day dates when dragging across daylight-saving changes. - Keep simultaneous reminders independently visible and actionable, including when the desktop notification-process limit is reached. --------- Co-authored-by: Jason Lee <huacnlee@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Fixes #237. The reader footer previously grew by one row for every genuine attachment. With 40 files in a 380×360 reader, its body had a negative height and the message could not be read. Removing embedded images in #272 does not address that case. Attachments now start as a single count with a Show/Hide control. Expanding them reveals an independently scrolling list, limited to 40% of the room left below the header and at most 160 theme-scaled pixels. A short list uses only its natural height. The disclosure and scroll position reset when the selected message or service changes, and messages without attachments reserve no attachment space. The existing filename/open and save controls remain, including per-mailbox/message routing and save-busy suppression. The attachment list uses inherited theme colors, filenames remain PlainText, and no classification, fetching, saving or backend behavior changes. This PR is independent of #312. ## Verification - `ui/tests/qml/tst_attachment_footer.qml` was written before the fix. The final tests were rerun against unchanged main (`af8a7ae`) with the real standalone controls: six failures, including a −851px body height with 40 genuine files. The patched suite passes all six cases plus setup/cleanup on Qt 6.11.2, with no warnings from the production-control run. - The cases exercise zero/one/few/many attachments, a 300×280 short/narrow reader, resizing, repeated collapse/expand, message switching, wheel scrolling to the final file, real pointer activation of both actions, composed mailbox/message IDs, and busy-state duplicate suppression. - Native `make validate` ran with an isolated Rust build: **640 Rust tests passed**, with 11 existing ignored tests; JavaScript and portable shell/source checks passed. It then stopped at the pre-existing host-libcurl-specific `tests/test_imap_ordering.sh` failure (`imap-id must deliver a message body`). The Makefile documents why that check depends on the Omarchy libcurl behavior. Aggregate validation is therefore **not fully green**, and subsequent aggregate stages did not run. - The full main QML suite was run separately through `tests/run_qml_native.py` using this checkout's newly compiled backend and the official Qt 6.11.2 Quick Test runner: **1,083 passed, zero failures**. An earlier run reused a sibling checkout's backend; the final run does not. The focused attachment tests also pass against the actual standalone `qs.Ui`/`qs.Commons` controls. - Separate Outlook HTTP tests passed (6 checks); sidebar resource-boundary tests passed (64 checks). `make qml-check` passed with the Qt 6.11.2 linter (existing unresolved-import/unqualified-access warnings); QML naming, PlainText source checks and `git diff --check` passed. - A fresh reviewer found no actionable code or security findings. It also exercised 300×280 through 900×600 readers at spacing scales 1, 7/6 and 1.5, resizing while scrolled to the end and shrinking the model. **Security: PASS for the changed UI boundary**; this is not a broader application audit. - The standalone host build/test suite and Omarchy plugin validation were not completed here. A separate `make test-app-qml` attempt was blocked by unavailable CMake in the direct execution environment. Live Omarchy/standalone-host mouse-and-keyboard verification across platforms remains outstanding. ## Visual evidence and draft status Comparable before/after offscreen captures were produced and inspected at 380×360 and 900×600, in light and dark themes at scale 1, using synthetic mail and the actual MessageReader plus standalone theme/control components. They cover the old overflowing footer, the collapsed count, the expanded list and its final file. In the small production-control fixture the patched body keeps 247px collapsed and about 146px expanded, versus −851px before. These captures are offscreen component renders, not a manual Omarchy desktop session. GitHub-hosted before/after attachments are still pending; the captures are retained locally and were not added to the repository or a media branch. This stays a draft pending GitHub-hosted before/after images and the required manual host verification; the automated checks do not replace those gates. ## Release Notes - Messages with many attachments keep their body readable. Show or hide the attachment list, and scroll through every file without losing the message actions. Co-authored-by: Codex <codex@openai.com>
## Summary Fixes #240 and #267. Diagnostics now retain the backend's fixed IMAP, SMTP, JMAP, mail, outbox, attachment, reader, account, cache, credential, and other shared error identifiers instead of replacing them with `unknown_error`. This extends the static-identifier coverage left after #285's Gmail/auth/calendar/upload update. The recorder still accepts only exact, explicitly listed strings. It does not accept error prefixes or arbitrary snake-case text, inspect source at runtime, retain raw server messages, or change the recorded fields. Existing reports are sanitized again when recorded or opened. The QML 128-character bound, bounded private storage, and explicit-only AI launch are unchanged. The source-drift regression now checks static error expressions across all Rust namespaces, including block-bodied mappings and stored outbox failure states. The source scan is a heuristic tripwire for these known forms. New matches require a manual review of the literal before adding it to the runtime allowlist. ## Verification - Reproduced the defect before the fix: the report round-trip and expanded vocabulary regression failed because fixed error identifiers became `unknown_error`. - `python3 tests/test_diagnostics.py`: 13 passed on 5b381fc, including persisted/report round trips, exact-value rejection, private-data-shaped identifiers, CR/LF/CRLF/NUL, storage modes, symlink/hardlink refusal, and explicit-only launch. - `make test-js`: passed. - Python syntax parsing and `git diff --check`: passed. - Independent read-only diff review found no actionable blocker; the reviewer separately reran all 13 diagnostics tests and the diff whitespace check. - [CI run 36712982070](https://github.com/huacnlee/omamail/actions/runs/36712982070): all 11 jobs passed for 5b381fc, including Rust/JavaScript/portable shell tests, published/unreleased API gates, and Linux/macOS/Windows standalone backend and application jobs. - [Native credential contracts run 36712982375](https://github.com/huacnlee/omamail/actions/runs/36712982375): all 3 platform jobs passed for the same head. - Full local `make test` / `make validate` was not run. The aggregate results above are hosted CI results; local validation was the focused diagnostics suite, JavaScript suite, syntax and whitespace checks. ## Security PASS for the affected diagnostics sanitization boundary in the focused tests: only the reviewed fixed vocabulary survives, while synthetic account names, server text, URLs, message identifiers, filenames, credential-shaped strings, and modified known identifiers are omitted from newly recorded entries and generated reports. Runtime matching remains exact. This is not a complete security audit. No UI layout or interaction changes; screenshot evidence is not applicable. ## Release Notes - Diagnostic reports now identify IMAP, JMAP, sending, attachment, and shared backend failures while continuing to omit private or unrecognized error text. Co-authored-by: Codex <codex@openai.com>
Fixes #238. The long-running backend cached Outlook access tokens against `Instant` alone. On Linux that clock stops during suspend, so an hour-long token could still appear fresh after a laptop had slept for several hours. Mail and Graph then reused the expired token until the backend restarted. Each cached token now keeps both a wall-clock and a monotonic deadline. Both must have more than the existing 60-second refresh margin remaining. Wall time includes the suspended interval and handles forward clock corrections conservatively; the monotonic deadline prevents a backward wall-clock correction from extending the token's awake lifetime. Mail and Graph retain their own actual `expires_in` lifetimes, including tokens shorter than an hour. An expired entry proceeds through the normal refresh path before the requested operation. This patch adds no retry loop or replay of a mail/calendar write, and leaves genuine invalid-grant handling unchanged. This is based directly on main (`af8a7ae`) and is separate from #316. Both touch the cache area in `credentials.rs`; when integrating them, retain this expiry constructor and lookup inside #316's cancellation-safe account lane, and update its additional token-cache fixture to the new expiry type. No unmerged #316 changes are included here. ## Verification - Four deterministic clock regressions failed with the previous monotonic-only decision and pass with the fix: long suspend for mail/Graph, forward/backward wall changes, different resource lifetimes and short suspend, and the exact 60-second boundary. Tests exercise the production constructor and lookup with controlled clock samples, including 0, 59, 60, 61, 3,600 and 86,400-second lifetimes. - Rust 1.98.1: the final full run passes all 644 unit/integration checks (570 unit tests and 74 integration tests; 11 explicit native/environment tests remain ignored by the standard command). The focused credential suite passes all 8 checks. - Qt 6.11.2: 1,075 main QML checks, 6 Outlook HTTP checks, 64 sidebar checks and the native HTML resource-isolation test pass. JavaScript/portable suites, full QML lint and whitespace checks pass. All-target Clippy passes with the two documented pre-existing lint classes (`collapsible_if`, `needless_return`) allowed. - `make validate` stops at the unchanged libcurl IMAP body-channel fixture on this Debian host's libcurl 8.14.1; pristine main fails the same fixture. The remaining standalone host target cannot start because CMake is absent. - A fresh independent review found no blocking issue. Security: **PASS** for the affected cache boundary. No credential destination, validation, serialization or public API change; no UI files changed. Clock behavior was simulated deterministically. A physical laptop suspend and live Microsoft mailbox were not exercised. The backend pin remains 0.10.7; installed users receive the fix through a subsequent backend release. ## Release Notes - Refresh expired Outlook mail and calendar tokens after a long suspend without restarting the backend. Co-authored-by: Codex <codex@openai.com>
## Summary Fixes #236. The attachment classifier no longer mistakes an XML declaration in a supported embedded invoice stream for a standalone XML attachment. This is deliberately narrower than accepting every file with a `%PDF-` prefix. A PDF-named attachment must have recognizable PDF object/stream framing, exact direct stream lengths and a complete classic cross-reference/footer sequence. Only the five declaration-marker bytes at the beginning of an uncompressed embedded XML or metadata stream are exempted. Every other active-content marker remains checked across the entire container. ## Security boundary - The recognizer skips strings, comments, arrays, dictionaries and length-bounded streams without rendering, decompressing or resolving external resources. Names are decoded before structural checks; duplicate keys, malformed lengths/declarations, truncation and unsupported framing retain the ordinary refusal. - Full-file decoded-name checks also cover bytes inside skipped spans. Regression fixtures cover an action reached through a cross-reference into another stream and a tolerant-reader compressed-object case. - Native action/form names, encrypted and object-stream content, xref streams, hybrid references and incremental-update references cannot use this exception. Dangerous filename and executable-magic checks remain before it. - The original attachment bytes are never rewritten. Refused `attachment.store` calls return no launch path and create no file. Saving is unchanged. Security: **PASS for the bounded exception and exercised refusal boundary**, following independent source review and final-build regressions. This is not an antivirus, a PDF conformance validator or a general guarantee that a PDF is safe. ## Compatibility limits The fix covers direct-length, uncompressed XML embedded-file streams (`text/xml` and `application/xml`) and XML metadata in a classic-xref PDF. Unsupported layouts, including indirect stream lengths, xref/object streams, encryption and incremental updates (including some signed PDFs), remain refused when they contain the blocked XML marker. The conservative raw-name guard can also retain false positives. Saving remains available. Current QML opens attachments through Rust `attachment.store`; the unused legacy Python opener retains its existing conservative behavior. The backend pin and API contract do not change. ## Verification - The independently readable synthetic PDF fixture failed on the original classifier and passes with the fix. It exercises invoice XML embedding, not PDF/A or Factur-X conformance. - Rust 1.98.1: `cargo test --locked --features integration-test-credentials` passed 656 tests, with 11 existing ignored tests. This includes all 16 PDF regressions covering valid LF/CRLF/BOM data, XML MIME names, disguised HTML/SVG/scripts, native PDF actions, malformed declarations/lengths, truncation, content beyond 64 KiB and refusal before writes. - PDF fixtures are marked binary; a Windows-style `core.autocrlf=true` checkout was reproduced changing their bytes before the attribute and verified byte-for-byte identical afterward. - Independent compiled classifier probes accept the valid fixture and refuse all 12 additional encrypted/action/malformed cases. Adversarial bytes are only inspected/classified, never rendered or executed. - JavaScript and portable shell/source checks passed as part of both aggregate runs. - `make test` and `make validate` stop at the existing host-libcurl-specific `test_imap_ordering.sh` failure (`imap-id must deliver a message body`). The Makefile documents that this check requires the Omarchy libcurl behavior and excludes it from portable CI. Therefore the aggregate validation is **not fully green**; subsequent aggregate stages did not run. - Main QML suite through `tests/run_qml_native.py` and the official Qt Quick Test runner (PySide6/Qt 6.11.2): **1,075 passed, zero failures**. This was run separately after the aggregate stopped. Hosted CI and native credential contracts passed on `3c17e9d`: [CI](https://github.com/huacnlee/omamail/actions/runs/36709664783), [native credentials](https://github.com/huacnlee/omamail/actions/runs/36709664791). This includes desktop packaging on Linux, macOS and Windows. ## Release Notes - Open supported PDF invoices containing embedded XML without treating their invoice data as a standalone XML attachment. - Continue refusing disguised active attachments and malformed or unsupported PDF exceptions; saving remains available. --------- Co-authored-by: Codex <codex@openai.com>
Opening several watched mailboxes could reject otherwise valid work in two places: the UI failed the 65th pending RPC immediately, and internal MIME/cache/large-JSON transfers all began at once despite the backend's eight-upload, 128 MiB reservation limits. This fixes #304 and fixes #250 together without increasing either backend limit. Accepted RPCs now wait in a FIFO behind the existing 64-frame window. Their deadline starts when sent, and a callback that submits more work joins the tail. Queued requests can be cancelled without dispatching them; an already-sent request keeps its slot until its reply or connection failure. One upload queue belongs to each backend connection and accounts for both declared bytes and slots. Parse, body-cache and large-request uploads share it. A failed or cancelled transfer holds its reservation until discard answers, including when ordinary traffic has filled the RPC window. Unconfirmed discard stops the connection rather than assuming its bytes were released. Disconnect and shutdown settle waiting transfers, and replies from a stopped connection cannot revive them. Cancellation can also withdraw the final domain operation while it is still queued, so staged bytes do not turn into a cancelled write. The existing byte-string encoding, chunk limits, per-operation size limits and Rust API remain unchanged. No provider HTTP retry policy or unrelated account behavior is changed. ## Verification - All 14 GitHub CI jobs passed on final head `6e3c367`, including standalone backend/app gates and production packaging on Linux, macOS and Windows, native credential contracts, and released/unreleased backend compatibility. - Native Rust suite passed: 566 unit tests (11 explicitly ignored), 33 CLI tests, and all remaining integration/doc-test targets. No Rust source or API contract changes. - Full JavaScript suite passed. The new production-bridge tests cover 225-request bursts, FIFO/reentrant admission, immutable payload snapshots, queued and active cancellation, the final uploaded-operation cancellation race, byte reservations, delayed discard, failed cleanup, disconnect/reconnect and callback exceptions during shutdown. - Final Qt 6.11.2 run passed 1,082 main QML tests, plus 6 Outlook HTTP and 64 sidebar tests. The focused backend suite passed 24/24. QML lint and `git diff --check` passed. - A real isolated Rust subprocess handled 225 RPCs plus 24 mixed large MIME/body-cache/JSON transfers through the production `Backend.qml` functions and `Upload.js`; readback matched the uploaded content and every queue/reservation drained. This is now available through `make test-backend-process` before its existing Quickshell fixtures. The optional subprocess fixture is Unix-only and refuses Windows before creating storage or starting a backend, because its native known folders cannot be isolated through HOME/XDG overrides. - Pristine-main regressions failed on the pending-request cap, excess upload reservations and shutdown drain. Tests for both review findings were also observed failing before their fixes. - A fresh independent reviewer found mutable queued parameters and exception-sensitive failure fanout. Both were fixed and rechecked; no remaining blocking findings in the reviewed scope. `make validate` is **not fully green locally**: its legacy libcurl `tests/test_imap_ordering.sh` fixture fails identically on pristine `af8a7ae` (the host curl returns the FETCH prefix without its literal body). Rust, JS and portable shell stages passed; the remaining QML/lint stages were run separately. Standalone composition requires missing CMake, and plugin/real-Quickshell validation requires missing Omarchy/Quickshell tools. The new native subprocess test does not substitute for a real Quickshell Process host or a live nine-account mailbox reproduction. This PR remains a draft with those local verification gaps disclosed. ## Security PASS for the affected framing, capacity, cancellation and payload-free diagnostic boundaries, based on independent review and the regression tests above. The affected boundary is bounded local RPC/upload scheduling over the existing private stdio connection. No new network, credential, filesystem or executable destination is introduced. ## Release Notes - Large mailbox refreshes wait for available backend capacity instead of intermittently failing with pending-request or upload-capacity errors. - Cancelled internal uploads release their staged data without running a queued mail operation. --------- Co-authored-by: huacnlee <5518+huacnlee@users.noreply.github.com>
## Summary Fix Reply and Reply All when following up on a message you sent. Previously Reply addressed the author (yourself); Reply All did the same and put the original To recipients in Cc, while dropping the original Cc list. - For messages from the draft-owning account or its known aliases, Reply keeps the original non-self To recipients; Reply All also keeps the original Cc recipients. - Incoming replies still honor Reply-To. Incoming Reply All now includes the original Cc list as well as the other To recipients. - Exclude the owning account's identities and deduplicate addresses case-insensitively across To/Cc. Another connected mailbox remains a legitimate recipient. Never copy Bcc. - Prefer the original sender identity for a sent-message follow-up. Recipient selection lives in the shared compose recipient rules, using existing account and send-as data. Based on current upstream `main` (`af8a7ae`); no backend API change. ## Verification - Four synthetic Qt regression cases fail on upstream and pass with the fix: sent Reply, sent Reply All, known alias in a merged-account context, and incoming Cc retention/deduplication. - All `make validate` stages pass: 566 Rust unit tests, 33 CLI tests, remaining Rust integration tests, JavaScript and shell/source checks, 1,079 main QML tests plus Outlook/sidebar suites, standalone composition, QML lint, plugin validation, and whitespace checks. A workstation server restart interrupted the standalone link after `make test` passed; `make -o test validate` completed the remaining stages successfully. - Socket fixtures ran in an isolated network/mount namespace to prevent unrelated workstation probes reaching synthetic servers. Screenshot captures passed for all four states before and after. No live mail was sent. ## Security **PASS — scoped draft-recipient boundary.** Sender/recipient headers pass through existing contact normalization before entering editable draft fields; tests exercise CR/LF removal, Bcc omission, account ownership and cross-field deduplication. The change adds no automatic send or new credential/network path. This verdict covers recipient selection, not a broader transport audit. ## Before / after Synthetic production Qt `ComposeView` captures with production standalone controls, Solarized Light, Qt 6.11.2 software rendering, scale 1, and identical 900 × 600 composer dimensions. `agent-browser` captured the labeled evidence pages at 940 × 700 and uploaded these PNGs through this PR's attachment input. These are component fixtures, not live-mail desktop screenshots; all addresses and messages are synthetic. The only surrounding page content is the evidence label. ### Reply to a sent message The original recipient replaces your own address in To. | Before | After | | --- | --- | |  |  | ### Reply All to a sent message The original To recipient stays in To, the original Cc recipient is retained, and your own address is excluded. | Before | After | | --- | --- | |  |  | ### Follow-up from a known alias The alias is recognized as yours and used as the preferred From identity; the original recipient goes in To. | Before | After | | --- | --- | |  |  | ### Incoming Reply All The original Cc recipient is now included alongside the other To recipient. Another connected mailbox remains a recipient. | Before | After | | --- | --- | |  |  | ## Release Notes - Reply to your own sent messages addresses the original recipients instead of yourself. - Reply All retains original Cc recipients and excludes your account's known aliases without duplicate recipients.
## Summary
Expose email link destinations and newsletter unsubscribe metadata
through the existing `omamail read` / `mail.read` result. This addresses
the remaining newsletter-workflow gap discussed in #154: the CLI already
lists, reads, sends and trashes mail, but previously discarded HTML
anchor destinations and unsubscribe headers.
- `message.links`: `{text, url}` entries from anchors in the sanitized
document, including links missing from a message's plain-text
alternative.
- `message.unsubscribe`: deduplicated `urls` from `List-Unsubscribe`,
plus the sender's `oneClick` declaration when an HTTPS destination is
available.
- Empty arrays and `oneClick: false` when this metadata is absent.
Plain-text URLs stay in the body text. Provider metadata availability
still applies.
This is an additive, provider-neutral read projection. No new command or
flag is needed, no QML dependency is introduced, and the plugin's
backend pin/API requirements do not change. Cross-account search is
tracked separately in #308.
## Boundaries
Link extraction reuses the existing bounded sanitized-document traversal
and validates the exported destination after HTML-entity decoding.
HTTP(S) destinations use the existing public-host spelling policy;
mailto destinations are returned as data. Raw HTML, image/resource URLs,
unrelated headers and document attributes remain excluded. Reading still
leaves read state unchanged and does not visit links or perform
unsubscribe actions.
`oneClick` reports the sender's declaration, not verified DKIM coverage
or permission to POST. The caller remains responsible for any subsequent
network request, including DNS/address validation. Header URL bytes are
not HTML-decoded.
## Verification
- All `make validate` stages passed across the initial run and the
resumed remaining-stage run after a local harness restart: 570 Rust unit
tests, 33 CLI tests, remaining Rust integrations, JavaScript/shell
checks, 1,075 main QML tests, 6 Outlook and 64 sidebar checks, the
native Qt resource-isolation test, standalone composition, QML lint and
plugin validation.
- Final focused verification after link-decoding/bounding refinements:
all 13 read/projection tests and the real CLI IMAP/MIME fixture passed.
The fixture verifies HTML-only anchors, entity decoding, folded
unsubscribe headers, unchanged plain text, BODY.PEEK and exclusion of
tracking-image URLs and unsafe schemes.
- Provider-neutral recording fixtures exercise all five provider
identities and verify no extra operation beyond the read; this is not
live-vendor interoperability evidence.
- Changed-file formatting and whitespace checks passed. Strict Clippy
exposed five pre-existing `collapsible_if` / `needless_return`
diagnostics in untouched calendar, credentials, IMAP and mail-test code;
all-target Clippy passed with only those two lint classes allowed.
## Security
**PASS — scoped to the new read projection.** Sender-controlled anchor
attributes are decoded once before destination validation; header
targets retain their original non-HTML interpretation. Tests cover
unsafe schemes, private/loopback and numeric-host spellings, ambiguous
HTTP syntax, credentials, CR/LF/NUL, backslashes, Unicode, encoded
quotes, HTML entities, missing metadata and nested-anchor label
amplification. The projection contains no DNS, network, browser,
process-launch or mail-mutation operation. Existing raw-content/resource
exclusions and document bounds remain in force. This is not an audit of
arbitrary downstream clients or live-provider behavior.
## Release Notes
- Show HTML link destinations and newsletter unsubscribe metadata in CLI
mail reads, enabling automation to find unsubscribe targets without
exporting raw HTML.
Personal Outlook/Hotmail accounts can sign in successfully but fail to load folders or sync mail because setup stores an empty tenant. The backend accepted a missing tenant as `consumers` but passed an empty tenant to URL validation, which rejected subsequent token requests. Normalize both missing and empty stored tenants to `consumers`, matching the existing personal-account behavior in `MicrosoftOAuth.js`. Use the same normalized value for the token URL and the shared token-rotation lock used by refresh and credential changes. Explicit tenant values remain unchanged. ## Verification On `cd3e45b`, reviewer runs of `cargo test --locked --offline --lib auth::credentials::tests:: -- --test-threads=1` and the same command with `auth::tests::` passed all 10 tests. These cover normalization, the exact token URL, credential rotation, destination validation, timeout, response bounds, and refusal to follow redirects. Transport tests used controlled loopback servers and synthetic credentials. Five independent review scopes found no code blocker; required CI results are currently absent. The author reports `cargo test --locked --lib`: 536 passed, 0 failed, 11 ignored, and `cargo fmt -- --check` passing. The author also reports the new tests failing against the old implementation; that negative run was not independently repeated. The new tests cover the helper and URL construction, rather than exercising the complete persisted-account refresh path. On a live installation, the author reproduced token failures with `"tenant":""` and restored syncing by manually changing the field to `"consumers"` and reloading the plugin. This verifies the configuration workaround; live testing of the patched binary is not documented. Full `make validate` was not rerun in this review because its harnesses create `/tmp` task artifacts prohibited by the review session. This Rust fix takes effect when a backend containing it is installed; the plugin pin remains `0.10.6`. ## Release Notes - Personal Outlook/Hotmail accounts no longer fail to sync mail because their saved tenant is empty. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
## Problem
At startup, `reconcileComposeReceipts()` asks the outbox whether
recovered drafts with a `pendingSendId` were delivered. When every one
of them was `sent`, `finish()` wrote `Recovery.empty()` to
`compose.recoverySave`. That object is presentation state and has no
`version`. The backend (`src/compose/mod.rs`) refuses records without
`version: 1` with `recovery_invalid`.
Because `-32000` is in `unsentRefusals`, the retry ladder resent the
same payload six times (1, 2, 4, 8, 16, 32 s). The stale record never
left disk, so the same failure and the "Draft recovery could not be
saved" warning returned on every launch. Receipt acks, which wait for a
durable save, were never released.
A local diagnostics report showed this as repeated
`compose.recoverySave` → `recovery_invalid` bursts, spaced exactly by
the retry ladder.
## Fix
When nothing is left to restore, write `{"version":1,"active":false}`,
the same record `clearComposeRecovery()` already writes.
`Recovery.empty()` stays as UI state. The backend is unchanged: refusing
unversioned records is correct.
## Verification
- Added `version === 1` and `active === false` assertions to the
existing
`test_sent_receipt_is_not_restored_and_is_acknowledged_only_after_durable_save`.
Before the fix it failed with `Actual: undefined, Expected: 1`. After
the fix the file passes 99/99.
- `make test` and `make validate` pass locally.
## Release Notes
Draft recovery no longer keeps failing to save, or warns on every
launch, after a recovered message turns out to have been sent already.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…320) ## What changes - **`/history` opens at once:** choosing `/history` from the slash-command suggestions with Up/Down and Return/Enter now opens the history list directly. Before, the first Enter only completed the text to `/history ` and a second Enter was needed. `/history` takes no argument, so the completion step added nothing. Partial `/clear` and `/diagnose` completion is unchanged. - **Back to chat from History:** the history view shows a `← Chat` control in the AI header, using the same `BackBar` as the reader and calendar detail pages, and the header reads `AI · History`. Before, Escape was the only way back. The button and Escape both go through `AgentPrompt.leaveHistory()`, which returns focus to the prompt field. - The history list now sits below the measured header instead of a fixed 28px offset, so the taller back button cannot overlap the first row. `docs/KEYS.md` records the `/history` behavior. ## Before / after Synthetic offscreen captures of the production `AgentPrompt` in the `tst_agent_interaction` harness, using the same 520×600 size, harness colors, software renderer and scale 1 for both. Baseline: `main` at `31a5bb1`. The only visible differences are the `← Chat` button and the `AI · History` title; the list moves down to clear the button. _Screenshot to be attached._ ## Verification - New `test_history_back_returns_to_chat`: the back button is hidden in chat, shown in History, sits above the list, and clicking it leaves History and focuses the prompt field. - `test_exact_commands_execute_and_partial_commands_complete` now asserts that choosing `/history` enters History with an empty field and no agent call. - `make test-qml` on this branch: 1158 + 6 + 64 passed, 0 failed. `make qml-check` exits 0. **Security: PASS.** This change is presentation only. It adds no backend request, network request or agent dispatch; the existing test asserts that `/history` makes no agent call. ## Release Notes - Choosing `/history` in the AI panel opens conversation history immediately. - AI conversation history has a back button to return to the chat. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Publish Omamail v0.10.8 from this branch. Release CI builds and verifies the plugin backends and all three standalone desktop packages, creates the tag and one release, then updates backend-version and the released API contract in this PR after verifying every public download. Merge this PR once the pin commit and required checks pass. Main receives the version and runtime pin together in one merge. ## Release Notes - Update the Omarchy backend and standalone desktop applications to v0.10.8. --------- Co-authored-by: Omamail Release <41898282+github-actions[bot]@users.noreply.github.com>
Load Sonnet optionally and keep personal words in an app-owned spelling.json through each host’s private configuration boundary. Extract settings normalization and spelling runtime state because Service.qml on the v0.10.8 base has only 73 bytes below the source size limit. Portable spelling and settings tests pass, including baseline absence and behavioral fault mutations. Configuration and source checks pass. Qt, Sonnet runtime and native-host checks require a Qt-equipped host.
Draw completed misspellings in the theme error color with Sonnet’s highlighter inactive. Offer up to five corrections, session Ignore and an app-owned personal dictionary through the text menu; corrections preserve one-step undo and reject stale positions. Route Ctrl+. through Keymap, KeyRouter and App, preserving body focus and IME handling. Document the fcitx5 punctuation-width conflict. Cover wrapped underline segments and alignment reflow alongside the existing composer, menu and optional-adapter QML tests.
Name the Arch and Debian/Ubuntu Qt 6 Sonnet and dictionary packages in the installation section. Explain restart discovery, graceful absence and app-owned personal words without installing system packages.
Observe output closure independently of full request and response queues so accepted exports can stop before committing a file. Keep clean stdin EOF and quit as drain barriers. Bring queue-pressure and real-pipe regressions along with the observer. Full native execution remains blocked here by unavailable locked dependencies. Save as .eml depends on this: an export whose client has disconnected must stop before it creates a file in Downloads, and that cancellation never fired while the request or response queue was full. It is kept as its own commit so it can be reviewed, or split into a separate pull request, on its own.
Require an explicit owning account and retrieve complete literals with EXAMINE and BODY.PEEK[]. Bound retrieval by 25 MiB and 25 seconds, with one export per account and two per process. Save unchanged bytes privately in Downloads using exclusive numbered filenames. Expose only mail.exportEml as the unreleased API 7 method over released API 6 and preserve the 0.10.8 pin. Validate inherited Darwin ACLs before writing mail bytes and normalize Windows-invalid filenames. API inventory, released-view comparison, diagnostics and parser checks pass. Reverting typed-literal decoding fails three core assertions; restoring it passes eleven. Full Cargo and native integration remain blocked by dependencies and sandbox sockets.
Capture account and native message identity when a menu opens, refuse stale or missing owners, and route Ctrl+Shift+S to the reader message or list cursor. Require a ready API 7 backend advertising mail.exportEml and provider support. Extract service message actions into a tested library to stay under 128 KiB. Show saving, success and error notices, clearing stale failures on retry. JS and source checks pass; the original method-only gate fails the API-minimum regression and the corrected gate passes. A fresh agent confirmed the review fixes. Qt validation, hand-testing and updated screenshots remain required. Security: NOT VERIFIED for native execution.
Save as .eml adds mail.exportEml and raises the backend apiVersion to 7. The standalone host's packaged smoke test still required 6, so the bundled backend was rejected on every platform. Raise the expected version and its test fixtures, as #293 did for 6.
Owner
Author
|
PASS — exact-head independent code review at head Independently verified, read-only:
One non-blocking note: the private install helper's header comment elsewhere still describes the versions as "0.10.7"; it identifies builds by commit, SHA-256 and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update this development copy from upstream v0.10.7 to the pinned upstream v0.10.8 release commit, preserving history and replacing the older feature implementations with the current upstream proposals:
15270baee2df4a68db1ec907dd250161f8365011.49dc3dcdf44aef24040f7d147bafd4f1e5afbf5b.78407ebd7aa6a399f3a3bd7132214f3f789bf8b0.The base is
2d5f2bd9890a3adee636a55df184108d0eda29b7(the upstream Release v0.10.8 merge). The three feature heads are merged in the order above into40d3df7ae1d132118d878ca3771ff8edeb7da54a(the export branch was first merged at7369370, then its follow-up78407eb, which raises the standalone app's expected backend API to 7). The final tree is identical to that combination except for the five repository-administrative files below; obsolete private feature fixtures absent from the combination are removed. No feature code or API metadata is modified relative to the combination.Repository-only changes
README.md: development-copy banner, upstream version and feature links; no release is published from this copy.AGENTS.md: repository ownership, public-data hygiene, testing and derivative release constraints..github/workflows/ci.yml: download the exact pinned backend fromhuacnlee/omamail, which publishes it, without changing either backend gate..gitignore: exclude/artifacts/and/.test-home/.docs/BACKEND-RUNTIME.md: distinguish this derivative's disabled publishing/comment workflows and branch protection from upstream release procedures, retaining the new upstream runtime documentation.Lost-fix audit
All four reviewed fixes are present in the feature combination:
e5ad88c:src/providers/imap/export.rs::single_literalrejects ambiguous or incomplete bodies (duplicate BODY/UID, partial sections and nonliteral bodies); dedicated raw-message refusal tests cover these paths.500b553:PersonalWords.qmlqueues writes, merges late loads and reports failures; both host config allowlists acceptspelling.json, standalone settings accept spelling preferences,SpellingState.qmltracks language changes, andSpellcheckAdapter.qml::applySettingsrefuses silent language fallback. Revision/layout guards and persistence/language tests remain.f485bf4:ComposeView.qml::onSpellingCorrectchecks the saved document revision and word before editing, then marks the draft edited and user-modified. Stale-word, dirty-state and undo tests remain.1f9f498:Spelling.js::underlineSegmentsincludes the caret after the final character and covers wrapped/descending segments, with JavaScript and composer tests.The personal dictionary remains compatible: old and new versions use
writeConfig("spelling.json", JSON.stringify({words: ...})), and the new loader reads the sameconfigPath("spelling.json")andwordsarray. No personal configuration or real mail was accessed.Verification
3a0a2e793632cf7c3ce1cf00f107c1a75cda28a0.git diffagainst the feature combination lists only the five files above.51d8357(identical to the final head except the two standalone smoke-check lines):make validateexited 0;make test-js,make test-shell,make test-qml,make test-app-qml,make qml-checkandmake test-rusteach exited 0. QML totals: 1,301 passed, 0 failed, 0 skipped. Rust totals: 729 passed, 0 failed, 11 ignored.cargo clippy --locked --all-targetsexited 0 with exactly the upstream baseline warnings.cargo fmt --checkreports the same two formatting diffs as the pinned upstream baseline (src/calendar/attendance.rs,src/providers/imap/read/search/tests/paging.rs); no formatting-only changes were made.78407eb, verified on Linux: standalonecargo test, release build, CMake build,ctest6/6 (includingtst_resources),tst_host_contract29 passed,test_backend_api.py --standaloneandmake test-app-qmlall passed.Release Notes