Repository navigation
Add a per-window Omarchy theme to the mail window - #13
Merged
Merged
Conversation
Applies the reviewed app-theme branch (8bfa83d, ledger 397) on top of private main as one change, without the three upstream fixes (#442-#444) that branch is based on, which private main does not carry yet. Two adjustments for the private tree: the appTheme default lives in settings/Settings.js, where private main moved the defaults out of Service.qml, and the Save as .eml toast takes its colours from Paint so it follows the window's theme like the rest of the window. Test branch only; not for main until the theme is decided upstream.
Private main's spellcheck made ComposeView's errorColor required; the window passes its urgent colour, and so does the fixture now.
The private build's spelling card used Style.normalFillFor, which on a themed window returns the desktop theme's fill; the theme branch's source check catches it. Every other settings card already goes through Paint.
Owner
Author
|
The only failing check, Standalone app (Windows x86_64), is the same EBUSY on a locked file in the backend API contract test that PR #12 hit and was accepted for: this build runs on Linux only. The theme changes no Rust or backend code; the Windows Qt tests in that job passed (7/7). The required Published backend merge gate passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets the mail window use any installed Omarchy theme instead of the desktop's. Settings → Appearance → Theme: Follow Omarchy (the default, unchanged behaviour) or any built-in or user-installed theme. The bar envelope, unread popup and desktop notifications keep the desktop theme; the standalone app keeps its Light/Dark/System setting.
Built on the upstream-shaped
app-themebranch (8bfa83d), applied over private main with two private-tree adjustments: theappThemedefault lives insettings/Settings.js, and the Save as .eml toast and spelling settings card take their colours from the theme.Verification
8bfa83d: PASS with notes, Security PASS (third round; F1–F11 from earlier rounds fixed).6608631: QML 1739 passed / 1 failed (the upstream November calendar fixture, which also fails on unmodified upstream), Rust 790 passed, standalone app, qml-check, plugin validate and source checks all pass.omamail-private install --test app-theme-test; works.Release Notes