Repository navigation
Add saved-file toast, reader entry points, and folder choice for Save as .eml - #10
Merged
Merged
Conversation
… Save as .eml - EmlSavedToast: a card naming the saved file and folder, with Open folder and dismiss; auto-hides after 8s, held while hovered. Status line note kept. - Reader: download button in the view toolbar (saves to Downloads) and Save as .eml / Save as .eml to folder... rows in the body's right-click menu. - Message menu: Save as .eml to folder... row beside Save as .eml. - mail.exportEml takes an optional absolute, normalized directory. A picked folder must already exist and pass the same ownership checks; it is never created. Downloads behaviour is unchanged. - attachment.sh folder: one folder through omarchy-file-select --directory (portal), falling back to zenity, out of process like the file picker. - Tests: Rust parse/write cases, contract case, shell picker cases, JS routing/stale-owner cases, QML toast/reader/menu cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving a message as
.emlwas easy to miss: it only worked from the inbox list, went straight to Downloads, and confirmed itself with a caption at the edge of the status line.What changes
Saved <file>andin ~/Downloads(or whichever folder was used), with Open folder... and a dismiss button. It hides after 8 seconds and stays while the pointer is over it. The existing status-line note is unchanged.scripts/attachment.sh folder→omarchy-file-select --directory, which uses the desktop portal, withzenityas the fallback), the same way the compose file picker avoids in-shell Qt dialogs. The standalone app does not offer the folder rows because it has no chooser.mail.exportEmlaccepts an optionaldirectory, which must be an absolute path already in normal form (no.., no., no doubled or trailing separators, no control characters). The folder must already exist and is opened through the same descriptor-anchoredprivate_fs::directoriesownership checks used for Downloads. It is never created; Downloads is still created on first use, as before. This stays within unreleased API 7.Security
Security: PASS for the export write boundary. Any path the chooser returns is still revalidated by the backend, which refuses it as
invalid_paramsbefore fetching anything unless it is absolute and in normal form. The write uses the same anchored directory walk, the same rules for rejecting group- or world-writable directories, and the same no-follow unique-name writer as Downloads. Tests verify that a missing chosen folder is not created (the side effect cannot happen), not merely that an error is returned. Owner capture is unchanged: if the user switches accounts while the chooser is open, the save is still refused (JS test).Verification
cargo test --locked --features integration-test-credentialsreports 642 passed and 1 failed. The failure isagent::jobs::tests::legacy_worker_compatibility_accepts_only_known_exact_script_argv, which also fails on unmodifiedmain(d281a64) on Hopebox and appears to depend on the environment. This PR adds export parse and write tests.EmlSavedToast, reader toolbar/body-menu, and message-menu folder-row cases.make test-js,tests/test_source.sh(including the 128 KiB file ceiling), andtests/test_attachment.sh(new folder-picker cases) all pass.omarchy-file-select --directoryexists on XPS and calls the portal FileChooser withdirectory=true.omamail-private install, which restarts the shell.Release Notes