Skip to content

Add agent document reviews - #150

Merged
lastobelus merged 7 commits into
mainfrom
t3code/agent-document-reviews-discovery
Aug 15, 2026
Merged

Add agent document reviews#150
lastobelus merged 7 commits into
mainfrom
t3code/agent-document-reviews-discovery

Conversation

@lastobelus

@lastobelus lastobelus commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Outcome

Adds the first agent-review cycle to the existing unreleased markover-review v1 format. One agent can claim a pristine review, return one atomic batch of annotations (and optionally source proposals), and leave a read-only reviewed artifact for the human without introducing a second protocol.

Linked work

Addresses #132

Scope

  • Included: agent-reviewing and reviewed lifecycle states; lifecycle-conditional review.agentReviewer attribution; dedicated reviewer-agent guidance; idempotent claim recovery; atomic whole-artifact submission; exact response-uncertain retries; full renderer convergence; PR, deletion, body-limit, and lifecycle race handling; CLI and authenticated local-service routes; developer/agent/user documentation.
  • Included: Settings → Agent Review → Agent review permissions, persisted globally with annotation-only as the default and annotations-and-source-proposals as the opt-in.
  • Deliberately excluded: mixed human/agent cycles, multiple reviewers, per-node authorship, attachments in agent submissions, direct source-file application, cross-review history, a new protocol family, and a v2/migration.

Validation

  • npm run check
  • npm test
  • Focused automated tests for changed behavior
  • Relevant manual macOS validation, when applicable
  • Before-and-after screenshots for meaningful visual changes, when applicable
  • Documentation updated, when applicable
  • Third-party notices regenerated for production dependency changes, when applicable

Validation details

  • npm run ci:local: 732 tests passed on head d56869c7 after rebasing onto current main at d00d5e96, plus lint, type checking, notices verification, and packaged smoke.
  • Added format/store tests for lifecycle invariants, pristine claims, unique claim IDs, same-clock stale claims, mode enforcement, additive-field preservation, structural-key ordering, exact retries, PR completion, deletion, and full-artifact convergence.
  • Added regression coverage for response-uncertain submit recovery after PR-driven archival, preserving the original receipt without mutating the terminal artifact.
  • Added service/CLI tests for the complete claim-submit flow, identity recovery, settings snapshots, serialization barriers, exact body boundaries, post-commit uncertainty, file/stdin submission, and receipts.
  • Added renderer/settings tests for reviewed-history placement, non-activating completion notices, zero-finding copy, and both global permission modes.

Manual macOS QA

  • Completed three end-to-end cycles in the explicit dev instance at head 6b83fc8e; the later conflict-free rebase to 7756bcc0 retained all six PR patches byte-for-byte according to git range-diff: annotation-only with atomic source-edit rejection and a successful two-finding batch; snapshotted source-proposal permission with non-activating completion; and a zero-finding submission with Reviewed history placement.
  • Verified claim attribution, read-only reviewing/reviewed states, settings in both global modes, completion notices, feedback rendering, and restoration of the default annotation-only setting.
  • Captured nine 1180×760 screenshots covering both settings modes and all three lifecycle cycles; the durable local QA record is tmp/pr-150-agent-review-qa/RESULTS.md in the PR worktree.

@lastobelus
lastobelus marked this pull request as ready for review August 13, 2026 03:36

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c717f753c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/renderer.ts
@lastobelus
lastobelus force-pushed the t3code/agent-document-reviews-discovery branch 3 times, most recently from d4208eb to 9bf361e Compare August 14, 2026 22:11
@lastobelus

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9bf361e703

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/markover.ts
@lastobelus

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 09323418ef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/review-sessions.ts Outdated
@lastobelus

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1e71573249

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/review-sessions.ts
@lastobelus

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 6b83fc8e15

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lastobelus
lastobelus force-pushed the t3code/agent-document-reviews-discovery branch from 6b83fc8 to 7756bcc Compare August 15, 2026 00:20
@lastobelus

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7756bcc063

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/review-store.ts
@lastobelus

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: d56869c76b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lastobelus
lastobelus merged commit 909f136 into main Aug 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant