Repository navigation
Run release currency through the shared hygiene workflow - #40
Merged
Merged
Conversation
The local copy of verify-tag-currency.sh still carried the moving-tag model and told a maintainer to force-push a moved tag, which contradicts the rule that a public release tag is never moved. The weekly check now calls laranail/.github's hygiene workflow, which runs laranail/package-tools' canonical script: a tag behind main is a warning that a release is due. The local script is deprecated in place. It prints a notice and delegates to the canonical script when an installed copy already follows the immutable-tag model, and otherwise keeps working, now advising the next patch.
PHPStan's strict rules now report negating a mixed value. Casting keeps the same truthiness the bare negation had.
Benchmark results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/tag-currency.yml: the release-currency job callslaranail/.github/.github/workflows/hygiene.yml@main(tag currency only), which runslaranail/package-tools' canonical script. Release tags are immutable, so a tag behindmainbecomes a warning that a release is due (Treat a tag behind main as a due release, never a tag to move package-tools#91) rather than a red run.scripts/verify-tag-currency.shis deprecated in place, not removed. It prints a::notice, then delegates to the canonical script when the installedvendor/laranail/package-toolscopy already follows the immutable-tag model andghis available. Otherwise it keeps working, with the force-push advice replaced by the next patch to cut. Earliest removal: the next minor release.[Unreleased]: Changed and Deprecated entries.Checks run locally
YAML parses; shellcheck clean. Both script paths were smoke-tested against the live repo: the fallback prints
cut v0.1.1, and delegation to the new canonical prints::warning title=Release due::and exits 0. Neither path printstag -for--force.No release tag is cut here; v0.1.1 waits on the owner.