Skip to content

Remove the settings store in favour of laranail/settings - #56

Merged
imanimanyara merged 2 commits into
mainfrom
feat/remove-settings-store
Nov 11, 2026
Merged

imanimanyara merged 2 commits into
mainfrom
feat/remove-settings-store

Conversation

@imanimanyara

Copy link
Copy Markdown
Member

Summary

Removes toolkit's settings store, now replaced by the dedicated laranail/settings package. This is a full removal, not a deprecation, as the owner decided.

Removed:

  • SettingsStore and SettingsStoreInterface;
  • ToolkitManager::settings() and the @method lines on both facades;
  • the two container bindings;
  • the laranail.toolkit.settings config block and its env keys;
  • the store's tests.

Kept, because none of them touch the store: isValidDatabaseConnection, RuntimeConfigurator and the feature toggles.

Docs:

  • CHANGELOG [Unreleased] → Removed. This is a breaking change for the next minor, 0.4.0.
  • UPGRADING explains how to move the JSON store into laranail/settings (--from=toolkit).
  • The architecture, configuration, installation and utilities pages are updated.
  • composer.json suggests laranail/settings.

Verification (local)

  • Pest: 1191 passed; PHPStan, Rector, Pint and composer validate are clean.
  • References: the remaining hits are the new CHANGELOG/UPGRADING text, the suggest entry, and a frozen 0.1.0 API-surface fixture that no code reads.
  • Consumers: sis-wrapper and crm-tools-vtiger-client have 0 references to the settings store.

Copilot AI balanced review requested due to automatic review settings November 11, 2026 18:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@imanimanyara
imanimanyara merged commit afb0c0e into main Nov 11, 2026
13 checks passed
@imanimanyara
imanimanyara deleted the feat/remove-settings-store branch November 11, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants