Repository navigation
Remove the settings store in favour of laranail/settings - #56
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes toolkit's settings store, now replaced by the dedicated
laranail/settingspackage. This is a full removal, not a deprecation, as the owner decided.Removed:
SettingsStoreandSettingsStoreInterface;ToolkitManager::settings()and the@methodlines on both facades;laranail.toolkit.settingsconfig block and its env keys;Kept, because none of them touch the store:
isValidDatabaseConnection,RuntimeConfiguratorand the feature toggles.Docs:
[Unreleased]→ Removed. This is a breaking change for the next minor, 0.4.0.laranail/settings(--from=toolkit).composer.jsonsuggestslaranail/settings.Verification (local)
composer validateare clean.suggestentry, and a frozen 0.1.0 API-surface fixture that no code reads.sis-wrapperandcrm-tools-vtiger-clienthave 0 references to the settings store.