Repository navigation
Drop the Codecov upload from CI - #54
Merged
Merged
Conversation
The Codecov GitHub App is uninstalled from every Simtabi-owned org, so these upload steps can no longer deliver anything. They were already advisory: the repository was never activated on codecov.io, which is why every run carried the "Codecov rejected the upload" warning the steps themselves emitted. Coverage enforcement is unchanged. The floor is still enforced by the test runner on every matrix row, the job summary still reports the numbers, and coverage.xml is still kept as an artifact. coverage-baseline.yml is kept: it stands in for a push trigger on the default branch, which is the weekly post-merge drift check, and that purpose does not depend on Codecov.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the Codecov upload from CI. Coverage itself is unchanged — it is still produced, still enforced, and still visible.
What stays
pest --coverage --min=<floor>fails the run below the floor, on every matrix row. That was always the enforcement; Codecov was advisory.coverage.xmlkept as a build artifact.What goes
The
codecov/codecov-actionstep, theCODECOV_TOKENsecret reference, and the "Report a rejected Codecov upload" step that existed only to turn a silent rejection into a visible warning. ZeroCODECOVreferences remain in.github/on this branch.The workflow comments are updated in the same commit, so they describe what the files now do rather than the Codecov baseline they used to refresh.
Why
The upload was already failing closed-but-noisy —
fail_ci_if_error: truewithcontinue-on-error: trueplus a warning step — which is three pieces of machinery to report that an advisory service rejected a push. Dropping it removes a secret from CI's reach and a third-party action from the supply chain, and loses no enforcement.