Repository navigation
Drop the Codecov upload from CI - #53
Merged
Merged
Conversation
The Codecov GitHub App is uninstalled from every Simtabi-owned org, so these upload steps can no longer deliver anything. They were already advisory: the repository was never activated on codecov.io, which is why every run carried the "Codecov rejected the upload" warning the steps themselves emitted. Coverage enforcement is unchanged. The floor is still enforced by the test runner on every matrix row, the job summary still reports the numbers, and coverage.xml is still kept as an artifact. coverage-baseline.yml is kept: it stands in for a push trigger on the default branch, which is the weekly post-merge drift check, and that purpose does not depend on Codecov.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Codecov GitHub App is uninstalled from every Simtabi-owned org, so the upload steps in this repository can no longer deliver anything. This removes them.
They were already advisory. The repository was never activated on codecov.io, which is why every run carried the "Codecov rejected the upload" warning those same steps emitted — the condition was anticipated in the workflow comments.
What is unchanged
coverage.xmlis still kept as a short-retention artifact.What is kept, and why
coverage-baseline.ymlstays. Its purpose is standing in for apush: branches: [main]trigger — the weekly post-merge drift check the org convention calls for — and that does not depend on Codecov. Only the upload step and its warning handler are removed.Verification
YAML parses and every job is intact; no
codecovreference remains anywhere under.github/.