Repository navigation
Throw SettingsMisuse for calls the package cannot serve - #25
Merged
Merged
Conversation
The five plain LogicException throws become SettingsMisuse, which still extends LogicException, so existing catch blocks keep working. A new SettingsError interface, implemented by SettingsMisuse and SettingsException, lets one catch take every settings exception. A source scan keeps bare LogicException out of src; it failed on the old code first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SettingsMisuse(extendsLogicException) replaces the five plainLogicExceptionthrows:Lookup::value()on a missing or redacted lookup,flush()withoutfor($owner),Settings::fake()with no application, and a settings migration before the provider is registered. Messages are unchanged, andcatch (LogicException $e)still catches them.SettingsErrorinterface, implemented bySettingsExceptionandSettingsMisuse, so onecatch (SettingsError $e)takes every settings exception.SettingsExceptionstill extendsRuntimeException.tests/Feature/MisuseTest.phpchecks each of the five call sites, that every class insrc/ExceptionsimplementsSettingsError(31 at least), and scanssrc(300+ files) for a bareLogicException. The scan failed on the old code first. Pest'sarch()cannot see built-in classes, so the scan reads the source.tools/exceptions.md(reference rows, a catch-all example),tools/settings-api.md, CHANGELOG[Unreleased].Local: 748 tests pass; Pint, PHPStan level max and Rector clean.