Repository navigation
Read the cache's time through Support\Clock - #24
Merged
Merged
Conversation
SettingsCache was the one class calling the global now() helper; every other class takes the package Clock. An architecture rule now refuses now() and today() outside the providers and facades, and was seen failing on the old code before the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found while running the per-PR merge checklist against v0.1.0 (8146f73).
SettingsCachewas the only class calling the globalnow()helper; every other class takes the package'sSupport\Clock. It now takesClockthe same way it takesBagCodec. Behaviour is unchanged: both read Laravel's date seam.now()andtoday()are refused outsideProvidersandFacades. Seen failing on the old code ("Expecting 'Simtabi\Laranail\Settings' not to use 'now'") before the fix.[Unreleased]entry.Local: 742 tests pass, Pint, PHPStan level max and Rector clean.