Repository navigation
Refuse colliding import keys and read sources from disks - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the two gaps in the importers that the consolidation audit found.
ImportedKeys::values()normalises every source key first. If two or more land on one settings key, the import throwsInvalidImportand lists every group ([Mail-Host, mail_host] -> mail_host). It fails in dry run and apply alike and writes nothing. The spatie, toolkit and akaunting importers all use it.DiskImportercontract is implemented byToolkitJsonImporterthrough the injected filesystem factory.import --disk=takes any disk, S3 included. With no source, it reads toolkit's ownlaranail.toolkit.settings.{disk,path}, and falls back tolocalwithlaranail/settings.json.import-export.md,importers.md,commands.md, the spatie recipe, and a new recipe for migrating fromlaranail/toolkit, plus README and CHANGELOG entries.Behaviour change
Two identical unscoped akaunting rows now fail the import instead of the last row winning.
Verification (local)
ksort.