Skip to content

Pre-release review: security and race fixes - #15

Merged
imanimanyara merged 6 commits into
mainfrom
fix/pre-release-review
Nov 11, 2026
Merged

imanimanyara merged 6 commits into
mainfrom
fix/pre-release-review

Conversation

@imanimanyara

Copy link
Copy Markdown
Member

Summary

Pre-release review. Every fix carries a regression test that fails without it.

Security

  • Persisted configuration refuses php and config layers. A persisted php layer could require any file on the server.
  • Persisted configuration may only add layers. It cannot redefine a layer the config file defines.
  • A change request is found only in its own store. A store's approve, reject or cancel route could act on another store's request.
  • Idempotent replays are encrypted and bound to the resolved actor and host. They were stored in plaintext and could be shared between actors.
  • An unfiltered audit query returns only the stores the actor may view_audit, and 403 when there are none.

Fixed

  • Reusing an Idempotency-Key with a different body answers 422.
  • DELETE with If-Match deletes only at that version (412 otherwise).
  • Concurrent approvals are both counted.
  • Values are limited by values.max_bytes: 1 MiB by default, and null turns the limit off.
  • A malformed cursor answers 422.
  • A malformed file record raises DriverFailure.
  • README quick start and the upgrade guide are corrected.

Release workflow

  • softprops/action-gh-release is bumped to v3.0.4.
  • -rc tags publish as pre-releases.
  • A final tag with no CHANGELOG section fails instead of publishing a stub.

Verification (local)

  • Pest: 673 passed; coverage 96.9 %.
  • PHPStan, Rector, Pint and composer audit: clean.

Copilot AI balanced review requested due to automatic review settings November 11, 2026 14:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@imanimanyara
imanimanyara merged commit 5d4213d into main Nov 11, 2026
14 checks passed
@imanimanyara
imanimanyara deleted the fix/pre-release-review branch November 11, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants