Repository navigation
Fix the schema to one shape and use Eloquent models as the data layer - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two design changes approved before the first release:
uid, and translations stored as JSON.tenancy.modeis the only switch:columnadds thetenantcolumns and keys.doctorchecks the real columns.SettingHistoryandSettingChangeRequest, with tenant scoping in oneBelongsToTenanttrait and global scope, and table names defined once. The five overlapping repositories are removed. The per-request value load inDatabaseDriverstays on the query builder for speed.Removed config keys
schema.path,identity.mode,ids.type,ids.owner_key,translations.mode,categories.soft_deletes,definitions.table,history.enabledandapprovals.table.Behaviour changes
slug.definitions.sourcesdefaults tocodeandconfig. Reading definitions from the database is opt-in, so cached reads stay at zero queries.updated_atonly when a row changes.Verification (local, SQLite)
composer audit: clean.