Repository navigation
Lift every active tag ruleset during a tag reset - #99
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reset-release-tags.pyused to disable only a tag ruleset named exactly "Protect release tags". Repositories set up earlier use other names (toolkit's is "release tags are final"), so a reset there would find nothing to lift and fail on the protected refs. The script now lifts every active tag ruleset, whatever its name, and restores each one infinally. Disabled tag rulesets and branch rulesets are left untouched.Tests
A new case covers two differently named active tag rulesets, one disabled tag ruleset and one branch ruleset. It fails against the previous script and passes with the fix. Full suite: 1774 passed; Pint is clean.