Repository navigation
Correct the stale mismatch count in the slug resolver - #101
Merged
Merged
Conversation
The docstring explained why the slug is read from `origin` rather than from
the directory name, and illustrated it with `pdf-toolkit` is `laranail/pdf`.
That checkout has been renamed to `pdf`, so the example named a directory
that no longer exists and the count was one too high.
Now six of laranail's 73 checkouts, with `env-tools` is `laranail/env-kit`
as the example, plus the command and date the figure came from so the next
reader can re-derive it instead of trusting it.
The resolver itself is unchanged, and still returns the real slug for a
mismatched directory: repo_slug_of('env-tools') gives 'env-kit'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repo_slug_of()reads a package's slug fromoriginrather than from its directory name, and itsdocstring explains why with a worked example. The example was
`pdf-toolkit` is `laranail/pdf`.That checkout has been renamed to
laranail/packages/pdf, so the example named a directory that nolonger exists, and the count beside it — "seven directories" — was one too high.
Comment only. The resolver is untouched.
What it says now
Six of laranail's 73 checkouts, with
env-toolsislaranail/env-kitas the example, and thecommand and date the figure came from, so the next reader re-derives it instead of trusting it.
The six, measured 2026-11-13 by comparing each
packages/*/basename againstgit -C <dir> remote get-url origin:env-toolslaranail/env-kitenv-tools-webuilaranail/env-kit-webuiinstallerlaranail/installer-headlessinstaller-webuilaranail/installer-weblivewire-flux-uikitlaranail/flux-uikitproduct-demo-modelaranail/demo-modeVerification
The function's behaviour is unchanged, including the case the docstring exists to justify:
repo_slug_of('pdf')pdfrepo_slug_of('env-tools')env-kitrepo_slug_of('package-tools')package-toolsrepo_slug_of('pdf-toolkit')pdf-toolkitAll 8 scripts in
scripts/compile. The released CHANGELOG entry that carries the same sentence ishistory and was left alone.