Skip to content

Run the cache-drop step under bash - #4

Merged
imanimanyara merged 1 commit into
mainfrom
chore/cache-step-shell-bash
Sep 6, 2026
Merged

imanimanyara merged 1 commit into
mainfrom
chore/cache-step-shell-bash

Conversation

@imanimanyara

Copy link
Copy Markdown
Member

Run the cache-drop step under bash

The step uses a POSIX command:

rm -rf "$(composer config cache-files-dir)/laranail"

Windows runners default to PowerShell, which parses that as Remove-Item and
fails the job outright - not a no-op, an error:

Remove-Item: D:\a_temp....ps1:2

It broke the windows-latest legs on laranail/email and laranail/console while
passing on ubuntu. This repo is Linux-only today, so the step works here - but
the org policy is Linux and Windows on every PR, and the failure would appear
the moment a Windows leg is added. Git Bash ships on the Windows images, so
shell: bash makes the one line portable without changing it.

Applied across every repo carrying the step, so the class of bug is closed
rather than fixed twice.

The step uses a POSIX command:

  rm -rf "$(composer config cache-files-dir)/laranail"

Windows runners default to PowerShell, which parses that as Remove-Item and
fails the job outright - not a no-op, an error:

  Remove-Item: D:\a\_temp\....ps1:2

It broke the windows-latest legs on laranail/email and laranail/console while
passing on ubuntu. This repo is Linux-only today, so the step works here - but
the org policy is Linux and Windows on every PR, and the failure would appear
the moment a Windows leg is added. Git Bash ships on the Windows images, so
`shell: bash` makes the one line portable without changing it.

Applied across every repo carrying the step, so the class of bug is closed
rather than fixed twice.
Copilot AI lite review requested due to automatic review settings September 6, 2026 12:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@imanimanyara
imanimanyara merged commit 416bd5c into main Sep 6, 2026
8 checks passed
@imanimanyara
imanimanyara deleted the chore/cache-step-shell-bash branch September 6, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants