Repository navigation
Run the cache-drop step under bash - #4
Merged
Merged
Conversation
The step uses a POSIX command: rm -rf "$(composer config cache-files-dir)/laranail" Windows runners default to PowerShell, which parses that as Remove-Item and fails the job outright - not a no-op, an error: Remove-Item: D:\a\_temp\....ps1:2 It broke the windows-latest legs on laranail/email and laranail/console while passing on ubuntu. This repo is Linux-only today, so the step works here - but the org policy is Linux and Windows on every PR, and the failure would appear the moment a Windows leg is added. Git Bash ships on the Windows images, so `shell: bash` makes the one line portable without changing it. Applied across every repo carrying the step, so the class of bug is closed rather than fixed twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the cache-drop step under bash
The step uses a POSIX command:
rm -rf "$(composer config cache-files-dir)/laranail"
Windows runners default to PowerShell, which parses that as Remove-Item and
fails the job outright - not a no-op, an error:
Remove-Item: D:\a_temp....ps1:2
It broke the windows-latest legs on laranail/email and laranail/console while
passing on ubuntu. This repo is Linux-only today, so the step works here - but
the org policy is Linux and Windows on every PR, and the failure would appear
the moment a Windows leg is added. Git Bash ships on the Windows images, so
shell: bashmakes the one line portable without changing it.Applied across every repo carrying the step, so the class of bug is closed
rather than fixed twice.