Repository navigation
style: apply pint - #2
Merged
Merged
Conversation
Formatting only, no behavioural change. These violations accumulated on main because CI triggers on pull_request, so nothing re-runs Pint after a merge - they surfaced as red checks on unrelated dependency PRs.
There was a problem hiding this comment.
Pull request overview
This PR applies Pint formatting across the IpIntel package and its tests to eliminate accumulated style violations and prevent unrelated PRs from surfacing red formatting checks.
Changes:
- Reorders
useimports and normalizes whitespace/alignment in PHP files and tests. - Normalizes string concatenation spacing (e.g.,
'.'concatenations and docblock spacing) without altering semantics. - Applies consistent array key alignment/spacing in config and DTO
toArray()methods.
Reviewed changes
Copilot reviewed 15 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Feature/ResolverChainTest.php | Import ordering and concatenation spacing in a request header key. |
| tests/Feature/ApiTest.php | Minor concatenation whitespace change in a test request URL. |
| src/Support/IpIntelConfig.php | Docblock spacing and config-key concatenation formatting. |
| src/Services/ResolverChain.php | Import ordering and docblock spacing normalization. |
| src/Services/IpIntelManager.php | Import ordering, docblock spacing, and concatenation whitespace in cache key / exception message. |
| src/Rules/ValidIp.php | Import ordering only. |
| src/Providers/IpIntelServiceProvider.php | Import ordering and concatenation whitespace in route prefix building. |
| src/Http/Requests/LookupRequest.php | Array alignment/spacing in validation rules. |
| src/Http/Controllers/LookupController.php | Import ordering and match-arm spacing/alignment. |
| src/Facades/IpIntel.php | Import ordering only. |
| src/Exceptions/SourceUnavailable.php | Concatenation whitespace in an exception message template. |
| src/Enums/Outcome.php | Match-arm spacing/alignment only. |
| src/Data/ThreatSignals.php | Array formatting in toArray(). |
| src/Data/PlaceInfo.php | Array formatting in toArray(). |
| src/Data/IpIntelResult.php | Import ordering, docblock spacing, and array formatting in toArray(). |
| src/Data/AsnInfo.php | Concatenation whitespace in label() and array formatting in toArray(). |
| src/Contracts/ResolvesCity.php | Import ordering only. |
| src/Contracts/ResolvesAsn.php | Import ordering only. |
| src/Contracts/DetectsThreats.php | Import ordering only. |
| src/Adapters/Local/AtlasDriver.php | Import ordering only. |
| src/Adapters/IpApi/IpApiDriver.php | Import ordering and concatenation/array formatting within request/memoization/log contexts. |
| src/Adapters/EdgeHeader/EdgeHeaderDriver.php | Docblock spacing normalization. |
| rector.php | Concatenation whitespace in configured paths. |
| config/ip-intel.php | Array alignment/spacing normalization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formatting only, no behavioural change. These violations accumulated on main because CI triggers on pull_request, so nothing re-runs Pint after a merge — they surfaced as red checks on unrelated dependency PRs.