Repository navigation
Drop the no-op Closure import from CommitFlowTest - #28
Merged
Merged
Conversation
The file has no namespace, so `use Closure;` imports a global class into the global scope. PHP emits "The use statement with non-compound name 'Closure' has no effect" on every test run. The type hint on line 73 resolves to \Closure without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
use Closure;fromtests/Feature/CommitFlowTest.php.Why
The file has no namespace, so the import names a global class in the global scope and does nothing. PHP 8.5 reports it on every run:
The
Closure $nexttype hint in the anonymous pipe class resolves to\Closurewithout it.Verified locally (PHP 8.5.11)
phpstan analyse --debug: no errors--testwith package-tools'pint.json: passed