Repository navigation
Update the PHP the Windows image ships before testing - #87
Merged
Merged
Conversation
setup-php reused the image's PHP 8.5.11 after 8.5.12 shipped a security fix, and roave/security-advisories refuses to install on it, so the Windows leg failed on every pull request. Set setup-php's update (read from the step's environment) off Linux so it upgrades to the latest patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The windows-latest image ships PHP 8.5.11, and setup-php reuses it unless
updateis set. After PHP 8.5.12 (2026-10-21) shipped a security fix,roave/security-advisoriesconflicts withphp >=8.5,<8.5.12, socomposerrefuses to resolve on the Windows leg.This sets
update: ${{ runner.os != 'Linux' }}in the cross-platform job's setup-php env. It is an environment variable in setup-php 2.x, not an input. Windows and macOS legs upgrade to the latest patch, and the ubuntu-only jobs are untouched.The same fix is merged in password-tools#21, password-history#20 and barua#21, where every PHP 8.5 Windows leg logged
Updated to PHP 8.5.12.