Repository navigation
Add the shared OSV and secret scans beside the local audit - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
sharedjob callinglaranail/.github's reusablesecurity.yml, which brings this repository an OSV.dev scan and a ggshield secret scan it has never had.Measured 2026-11-13 across laranail: of 88 packages calling a reusable
laranail/.githubworkflow,security.ymlhad 1 caller againsttests.yml's 39 — while 23 packages ship a standalonesecurity.yml, 20 of which runcomposer auditand nothing else. The estate was unshared rather than unscanned; what this adds is the two scans, not scanning as such.Why the local
auditjob is left exactly as it isIt is not redundant, and replacing it would have been a removal disguised as a migration. This repository's job caches composer, pins its own PHP version and extensions, and on some packages in this pilot runs through a local container action — none of which the shared workflow does. So both run. Dropping the duplicate
composer auditis a separate decision to take later with evidence from these runs, not a side effect of this one.The secret scan before the credential exists
The shared workflow declares
OP_SERVICE_ACCOUNT_TOKENoptional and, when it is absent, emits a warning and skips the ggshield step rather than failing. Sosecrets: inheritis correct both now and once the credential is set. Failing closed is right for a finding — a leaked credential must stop the build — and wrong for a missing setting, which would redden every caller for a reason none of them introduced.Pilot
One of five:
package-tools,console,db-tools,chrono,package-management. The first runs will surface whatevercomposer auditand OSV have been missing, which is the point and also the reason the pilot is five repositories rather than twenty-three.