Skip to content

Take over the tidy command from laranail/toolkit - #14

Merged
imanimanyara merged 2 commits into
mainfrom
feat/tidy-from-toolkit
Oct 6, 2026
Merged

imanimanyara merged 2 commits into
mainfrom
feat/tidy-from-toolkit

Conversation

@imanimanyara

Copy link
Copy Markdown
Member

The owner moved toolkit's maintenance command here as
laranail::artisan-ui.tidy; toolkit drops it in 0.3.0. The logic is ported
unchanged, with every safety guard: storage_path() containment, refusal of
unfiltered user-file sweeps, and migrate:fresh kept out of all and gated.
Only the collaborators changed: Laravel's cache contract and a PSR logger
instead of toolkit's services, and the path guard as an internal trait.
Its tests come across with it, including the user-file guard regressions.

It is classified Destructive, since one name covers every action and db
runs migrate:fresh. A Tidy quick-action group offers the regenerable
actions only (cache, old logs, temp; each with a dry-run preview). Nothing
reaches storage or db in one click. The Caches group gains clear-compiled,
the one action toolkit's unloaded tidy routes had that was missing here.

The owner moved toolkit's maintenance command here as
laranail::artisan-ui.tidy; toolkit drops it in 0.3.0. The logic is ported
unchanged, with every safety guard: storage_path() containment, refusal of
unfiltered user-file sweeps, and migrate:fresh kept out of `all` and gated.
Only the collaborators changed: Laravel's cache contract and a PSR logger
instead of toolkit's services, and the path guard as an internal trait.
Its tests come across with it, including the user-file guard regressions.

It is classified Destructive, since one name covers every action and `db`
runs migrate:fresh. A Tidy quick-action group offers the regenerable
actions only (cache, old logs, temp; each with a dry-run preview). Nothing
reaches storage or db in one click. The Caches group gains clear-compiled,
the one action toolkit's unloaded tidy routes had that was missing here.
Copilot AI balanced review requested due to automatic review settings October 6, 2026 09:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

The tidy tests delete files under storage/logs, laravel.log included, while Monolog holds it open. Windows cannot reopen a file with a pending delete, so every later log write threw and the Windows leg failed. No tidy test asserts on log output; route it to the null channel.
@imanimanyara
imanimanyara merged commit c228be8 into main Oct 6, 2026
11 checks passed
@imanimanyara
imanimanyara deleted the feat/tidy-from-toolkit branch October 6, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants