Repository navigation
Take over the tidy command from laranail/toolkit - #14
Merged
Merged
Conversation
The owner moved toolkit's maintenance command here as laranail::artisan-ui.tidy; toolkit drops it in 0.3.0. The logic is ported unchanged, with every safety guard: storage_path() containment, refusal of unfiltered user-file sweeps, and migrate:fresh kept out of `all` and gated. Only the collaborators changed: Laravel's cache contract and a PSR logger instead of toolkit's services, and the path guard as an internal trait. Its tests come across with it, including the user-file guard regressions. It is classified Destructive, since one name covers every action and `db` runs migrate:fresh. A Tidy quick-action group offers the regenerable actions only (cache, old logs, temp; each with a dry-run preview). Nothing reaches storage or db in one click. The Caches group gains clear-compiled, the one action toolkit's unloaded tidy routes had that was missing here.
The tidy tests delete files under storage/logs, laravel.log included, while Monolog holds it open. Windows cannot reopen a file with a pending delete, so every later log write threw and the Windows leg failed. No tidy test asserts on log output; route it to the null channel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owner moved toolkit's maintenance command here as
laranail::artisan-ui.tidy; toolkit drops it in 0.3.0. The logic is ported
unchanged, with every safety guard: storage_path() containment, refusal of
unfiltered user-file sweeps, and migrate:fresh kept out of
alland gated.Only the collaborators changed: Laravel's cache contract and a PSR logger
instead of toolkit's services, and the path guard as an internal trait.
Its tests come across with it, including the user-file guard regressions.
It is classified Destructive, since one name covers every action and
dbruns migrate:fresh. A Tidy quick-action group offers the regenerable
actions only (cache, old logs, temp; each with a dry-run preview). Nothing
reaches storage or db in one click. The Caches group gains clear-compiled,
the one action toolkit's unloaded tidy routes had that was missing here.