Repository navigation
Authenticate composer's API path too, not just its git path - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#30 added a credential for private cross-org dependencies and authenticated one of the two routes composer can take.
laranail/sis-wrapperthen failed on the other:The token minted correctly and the guard passed — the log shows "Inputs 'owner' and 'repositories' are set. Creating token". The clone rewrite simply was not the path composer used.
Both paths, because the caller picks which one
Which route composer takes is decided by the dependency's own
composer.json, not by this workflow:GET api.github.com/repos/<o>/<r>/zipball/<sha>COMPOSER_AUTH→github-oauthno-api)git cloneof the plain https URLgit config url.insteadOf→x-access-token:<token>#30 set only the second. Setting only one fixes only half the callers — and the half it misses fails with an error naming neither authentication nor the token. A private zipball answers
404, which reads as "no such release" rather than "not authorised", so the symptom points away from the cause. That is the same shape as the originalGITHUB_TOKENfailure this whole thread started from.Verified
COMPOSER_AUTH=written at 2 sites,git config --global url.at 2 sites — one pair per composer-installing job (composer-audit,osv-scan).secret-scaninstalls nothing.GITHUB_ENVinside the job and revoked at job end. Nothing long-lived is stored, and the value never appears in a log — Actions masks it.Follow-up
laranail/sis-wrapper#51 re-runs against this.