fix(user-feedback): add missing lib/utils.ts excluded by root .gitignore - #36
Open
shubham88fru wants to merge 1 commit into
Open
fix(user-feedback): add missing lib/utils.ts excluded by root .gitignore#36shubham88fru wants to merge 1 commit into
shubham88fru wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15
Problem
The
user-feedbackexample doesn't build out of the box. Reproducing with the Dockerfile from the issue:20
.tsxfiles in the example importcnfrom@/lib/utils, butapplications/user-feedback/lib/isn't in the repository at all.Root cause
The file was never committed. The repo-root
.gitignorecontains alib/rule inherited from the gitignore.io Python template:Because that pattern has no leading slash, git applies it to a directory named
libat any depth — includingapplications/user-feedback/lib/. So whenshadcngeneratedlib/utils.ts, a subsequentgit addsilently skipped it, and it was never noticed locally because the file exists on disk and the app builds fine there.Confirmed on
main:Why the other examples aren't affected
applications/custom-annotation-uihit the same trap and already carries the fix — its.gitignorehas a!libnegation, and as a result its sixlib/*.tsfiles are tracked normally:This PR simply brings
user-feedbackin line with that existing convention.Changes
Two files, 7 lines:
applications/user-feedback/.gitignore— add!libimmediately after!.yarn/versions. This region is now byte-identical tocustom-annotation-ui/.gitignore. Without this,lib/utils.tscannot be staged at all.applications/user-feedback/lib/utils.ts— the standard shadcncnhelper, byte-identical toapplications/custom-annotation-ui/lib/utils.ts.clsxandtailwind-mergewere already declared inpackage.json, so no dependency changes are needed.I deliberately left the root
.gitignorealone to keep this fix minimal — happy to send a follow-up scoping thatlib/rule to/lib/if you'd prefer to prevent recurrences at the source.Verification
Before (
main,lib/absent) — dev server returns HTTP 500 with the exact error from the issue.After (this branch) — HTTP 200,
npm run buildexits 0 (✓ Compiled successfully).npm run lintreports 16 pre-existing problems inprompt-input.tsxandbranch.tsx. I verified against a pristine checkout that this is the unchanged baseline onmain, so this PR introduces no new lint issues. Left untouched as out of scope.End-to-end run against real OpenAI + Langfuse Cloud credentials — the chat UI renders, GPT-4o Mini responds, and the feedback score reaches Langfuse (
/api/public/ingestion→201, visible in the Network tab):Note on #29
#29 (
kiro-langfusemissinghooks/lib/) appears to have the same root cause — that path is caught by the same line 293 rule. It needs several modules reconstructed rather than one, so I've kept it out of this PR, but I'm happy to pick it up separately if that's useful.