Skip to content

Fix missing laminas-migration bin and autoload path#2

Merged
weierophinney merged 4 commits intolaminas:masterfrom
arueckauer:fix/composer-bin
Oct 31, 2019
Merged

Fix missing laminas-migration bin and autoload path#2
weierophinney merged 4 commits intolaminas:masterfrom
arueckauer:fix/composer-bin

Conversation

@arueckauer
Copy link
Copy Markdown
Member

Q A
Bugfix yes
BC Break no
New Feature no
RFC no

Description

Following the installation steps described here, the laminas-migration is not present in the global vendor/bin directory, due to a missing bin configuration in composer.json.

Secondly, invoking the laminas-migration command will fail due to an incorrect path to autoload.php.

This PR fixes both issues.

If desired, it is possible to change requiring the autoload file depending on whether the package was installed either as global or dev dependency.

Comment thread bin/laminas-migration Outdated
@michalbundyra michalbundyra added the Bug Something isn't working label Oct 31, 2019
Copy link
Copy Markdown
Member

@michalbundyra michalbundyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Copy Markdown
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

weierophinney added a commit that referenced this pull request Oct 31, 2019
@weierophinney weierophinney merged commit f407a3f into laminas:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants