Repository navigation
Conversation
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
方針レビュー待ち:DM-200 / v1。 作品・頒布・記事とイベントの関係、コア・支援・汎用の分類、依存と状態管理、今回の実装範囲をR1〜R8で先に判断します。現在の配置・規約・ArchUnit規則は未採用の比較案であり、レビュー後の修正対象です。
現在のhead
c445f5289cdcd6d77eda63a88855e1ae3e1356f8は、基準e4ae67188c0de2d767cfc12519f38f3d62debab4に対し、ArtistCredit/ArtistCreditName/EventReleasedAt/ExternalAudioUrlをalbumへ、EventDateAndSpaceをeventへ移した案です。commonに残した値の分類と、この配置を固定する検査も再評価します。このPRを現状のまま#200の完了根拠にはしません。現存VOの棚卸しと、移設前後で挙動を維持した証拠は再利用できます。Corretto 25.0.4.10.1/Gradle 9.7.1、Java blocklist適用で対象732試験、統合試験コンパイル、main/test Checkstyle・PMD・Spotless、CSP関連3試験が成功しました。これは設計方針の採用を示しません。DB統合試験と全E2Eはローカル実行の対象外でした。
次の判断は、作品・頒布・記事へ属する責務、アセット・サイト運営等の支援候補、文書形式・日時・URLの汎用処理とサービス固有方針の境界です。コアでは識別・不変条件・訂正と編集・状態遷移・再構築・複数モデルの整合性を評価し、分類後に型の所属と検査を決めます。#89/#148/#562/#276と対応付け、外部所有先・公開APIの決定へ渡します。
レビュー観点:
Refs #200, #201, #248, #471, #89