Repository navigation
dag: drop the REDUCE_STORE/MODULE_STORE exports - #61
Merged
Merged
Conversation
They were exported for cache warmers, and none exists in forest, arboretum, tree-calculus or lambada. cache_store and fingerprint stay: lambada's expect-test.js uses both. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F7tEJcozJkRf64wP1GFGLa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Johannes · project thread
Before:
main-dag.mts(and sobin/dag.js) exportedREDUCE_STOREandMODULE_STORE"for cache warmers".After: those two are no longer part of the library surface. No cache warmer exists;
git grepacross forest, arboretum, tree-calculus and lambada finds no consumer.How: removed them from the re-export, dropped the cache-warmer rationale from the comments in
main-dag.mtsandmodule/cache.mts, and rebuiltbin/dag.js.cache_storeandfingerprintstay exported, since lambada'sbin/expect-test.jsuses both. The constants stayexported insidecache.mtsbecauserunner/native.mtsimports them.Ran locally: the TypeScript tests,
bin/build.sh(only the expectedbin/dag.jschange), dag-machinetest.shand pcretest.sh, all passing.🤖 Generated with Claude Code
https://claude.ai/code/session_01F7tEJcozJkRf64wP1GFGLa
Generated by Claude Code