[experiment] Aad on nrf54 - #94
Open
WilliamTakeshi wants to merge 2 commits into
Open
Conversation
send each item on its own descriptor. avoid a big copy
Member
|
Good thing: This looks working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR remove the copy the AAD on a buffer.
Before
CCM encrypt/decrypt built the whole authenticated header in one [u8; 288] stack buffer: it copied b0, the 2-byte AAD length prefix, and then every chunk of the AadGenerator into that buffer, and finally handed the buffer as a single descriptor to the nRF54 scatter-gather engine.
After
We no longer copy the AAD. The header is fed as a sequence of descriptors that point directly at the caller's memory: