New data endpoint for dynamic liquidsoap config creation by tuz666 · Pull Request #232 · lahmacunradio/arcsi

tuz666 · 2026-07-27T17:29:40Z

/## Why make changes? State your reason

From programming point of view we're planning to extend our schedule for quite a long time, although the current design is not capable to return different weekly schedules.

As part of this PR my aim is to introduce week parameters for the schedule endpoints with a default value of 1, in order to remain compatible with the current frontend / mobile application implementation.

The schedule change will let us handle biweekly and monthly shows properly, and give us a bunch of time slots for possible new show ideas, but it will impact the usage of our Liquidsoap custom configuration as well, that will be handled in a much more flexible way.

What has changed? Describe your work

The following endpoints were extended with an additional week parameter:

/show/all_schedule: used by the frontend
/show/schedule: used by the mobile application
/show/schedule_by: not used by anyone, just aligned with the other changes

A new data endpoint (/data/weekly_schedule) is also created, it generates the custom Liquidsoap configuration script. The script has two dynamic parts: the playlists' initialization and their scheduling.
The new endpoint is generating this file from the current state of the Arcsi DB. There are 3 template files, one for the initialization, one for the scheduling and another with the static part of the script. The shows are used for templating the first two code snippets and they are inserted into the boilerplate file at the following lines: (initialization and scheduling).
It also has a week parameter but by default it returns the actual week's data.

Added LIQUIDSOAP_VERSION variable into config.template.py, with the help of this the possible future Liquidsoap syntax changes can be tracked.

How to review? Add scenarios or information on the output

The PR is deployed to the dev server, the new and modified endpoints can be easily reviewed there.

Notes. Share the github issue link, source link, or anything else

Another PR is expected to kick-off the multi week migration, there are two possible solution for this:

change Show.week Int field into an array or
combine the Show.week and Show.frequency

Extending schedule endpoints to support week query param

…k (no changes required from App side)

…g.py

pvj

Two questions quickly that I have about the overall picture.

What's the reason to have 2 separate tpl's and functions (one for init, and one for the schedule)? Is it because of schedule changes without show addition/removal are lightweight this way?
Did you think about creating a Schedule class for the Liquidsoap things? Those global environment.filters are a bit weird. And also I would say, I think the file name should reflect something ore generic like schedule.py and then we can create the LiquidsoapSchedule class or whatever.

tuz666 · 2026-08-31T21:24:52Z

Thanks for the comments @pvj !

What's the reason to have 2 separate tpl's and functions (one for init, and one for the schedule)? Is it because of schedule changes without show addition/removal are lightweight this way?

I thought it would be better to handle them separately, because they have a different purpose.
Although they can be queried via the same API call, but they are separated in the response as well.

Did you think about creating a Schedule class for the Liquidsoap things? Those global environment.filters are a bit weird. And also I would say, I think the file name should reflect something ore generic like schedule.py and then we can create the LiquidsoapSchedule class or whatever.

A really good idea, generalization is always welcome!
I haven't used that much OOP in python, so let me know, if anything could be written nicer.

pvj

API calls look good, code is good too so I think we can move forward with this. Thanks!!

pvj · 2026-09-07T10:43:35Z

-              "    pm.expect(shows).to.be.an(\"array\")\r",
-              "    shows.forEach(function(show) {\r",
-              "        pm.expect(show).to.be.an(\"object\")\r",
-              "        pm.expect(show.items).to.be.an(\"array\")\r",


Thanks for keeping this updated!

pvj · 2026-09-07T10:45:24Z

+init.daemon.pidfile.path.set("/var/azuracast/stations/lahmacun_radio/config/liquidsoap.pid")
+
+log.stdout.set(true)
+log.file.set(false)
+
+settings.server.log.level.set(10)
+
+settings.server.socket.set(true)
+settings.server.socket.permissions.set(0o660)
+settings.server.socket.path.set("/var/azuracast/stations/lahmacun_radio/config/liquidsoap.sock")
+
+settings.harbor.bind_addrs.set(["0.0.0.0"])
+
+settings.tag.encodings.set(["UTF-8","ISO-8859-1"])
+settings.encoder.metadata.export.set(["artist","title","album","song"])
+


Just thinking out loud, maybe some of these variables could be stored in config so it is easier to change settings.

It is a very minor case nothing serious as we don't really touch them

I would leave this as it is now, but I agree that this should be configurable in the future.

pvj

Great job, good addition!

New data endpoint for dynamic liquidsoap config creation

9faac73

Extending schedule endpoints to support week query param

tuz666 temporarily deployed to dev July 27, 2026 17:29 — with GitHub Actions Inactive

Align /show/schedule endpoint to only return shows of the current wee…

15818cd

…k (no changes required from App side)

tuz666 temporarily deployed to dev July 30, 2026 19:10 — with GitHub Actions Inactive

tuz666 had a problem deploying to dev July 30, 2026 19:39 — with GitHub Actions Failure

tuz666 had a problem deploying to dev July 30, 2026 19:47 — with GitHub Actions Failure

tuz666 had a problem deploying to dev July 30, 2026 19:49 — with GitHub Actions Failure

tuz666 had a problem deploying to dev July 30, 2026 19:54 — with GitHub Actions Failure

tuz666 had a problem deploying to dev July 30, 2026 20:04 — with GitHub Actions Failure

tuz666 had a problem deploying to dev July 30, 2026 20:09 — with GitHub Actions Failure

tuz666 force-pushed the dev/new-schedule-endpoints branch from 6e22086 to 15818cd Compare July 30, 2026 20:12

tuz666 temporarily deployed to dev July 30, 2026 20:12 — with GitHub Actions Inactive

tuz666 had a problem deploying to dev July 30, 2026 20:14 — with GitHub Actions Failure

tuz666 force-pushed the dev/new-schedule-endpoints branch from 5c011b2 to 15818cd Compare July 30, 2026 20:20

tuz666 temporarily deployed to dev July 30, 2026 20:20 — with GitHub Actions Inactive

Create separate files for playlist templates, add versioning to confi…

a14df02

…g.py

tuz666 deployed to dev August 2, 2026 22:02 — with GitHub Actions Active

tuz666 added enhancement New feature or request back-end configuration This issue includes settings of the environment labels Aug 3, 2026

tuz666 marked this pull request as ready for review August 3, 2026 15:05

Update Swagger docs, remove /show/all

ee6354c

tuz666 deployed to dev August 25, 2026 20:53 — with GitHub Actions Active

tuz666 requested a review from pvj August 25, 2026 21:03

pvj reviewed Aug 30, 2026

View reviewed changes

Introduce Scheduler and LiquidsoapScheduler classes

1e8a3e7

tuz666 deployed to dev August 31, 2026 21:03 — with GitHub Actions Active

fix typo

36f3124

tuz666 deployed to dev August 31, 2026 21:05 — with GitHub Actions Active

return the whole liquidsoap config file

cdd4989

tuz666 deployed to dev September 6, 2026 02:46 — with GitHub Actions Active

tuz666 requested a review from pvj September 6, 2026 02:54

pvj previously approved these changes Sep 7, 2026

View reviewed changes

tuz666 added 2 commits September 7, 2026 13:09

extend make_schedule_script to cover the whole creation

ca081af

bump arcsi image version

7f55a57

tuz666 dismissed pvj’s stale review via 7f55a57 September 7, 2026 11:11

tuz666 deployed to dev September 7, 2026 11:11 — with GitHub Actions Active

comment for get_end_time

32ee979

tuz666 deployed to dev September 7, 2026 11:14 — with GitHub Actions Active

tuz666 requested a review from pvj September 7, 2026 12:43

pvj approved these changes Sep 8, 2026

View reviewed changes

tuz666 merged commit dcc2119 into master Sep 8, 2026
1 check passed

Navigation Menu

New data endpoint for dynamic liquidsoap config creation - #232

New data endpoint for dynamic liquidsoap config creation#232
tuz666 merged 10 commits into
masterfrom
dev/new-schedule-endpoints

tuz666 commented Jul 27, 2026 •

edited

Loading

Uh oh!

pvj left a comment •

edited

Loading

Uh oh!

tuz666 commented Aug 31, 2026

Uh oh!

pvj left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pvj Sep 7, 2026

Uh oh!

pvj Sep 7, 2026

Uh oh!

tuz666 Sep 7, 2026

Uh oh!

pvj left a comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

tuz666 commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What has changed? Describe your work

How to review? Add scenarios or information on the output

Notes. Share the github issue link, source link, or anything else

Uh oh!

pvj left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tuz666 commented Aug 31, 2026

Uh oh!

pvj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pvj Sep 7, 2026

Choose a reason for hiding this comment

Uh oh!

pvj Sep 7, 2026

Choose a reason for hiding this comment

Uh oh!

tuz666 Sep 7, 2026

Choose a reason for hiding this comment

Uh oh!

pvj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tuz666 commented Jul 27, 2026 •

edited

Loading

pvj left a comment •

edited

Loading