Repository navigation
Play with one docker command, and print the link once the server is up - #56
Merged
Merged
Conversation
… with one docker command Once the server accepts connections it prints the game's name and version and, on a line of its own so terminals make it clickable, the link to open: the login page, or the game itself in a --user session. The address is the bind address, with a wildcard read as localhost, unless RYLWEEN_PUBLIC_URL or --public-url names another; the start log event records it too. With that, a machine with only Docker or Podman and internet access plays with one command, which the README now leads with: docker run --rm -it --pull always --name rylween -p 127.0.0.1:8081:8081 -v rylween-data:/data -e RYLWEEN_AUTH_SECURE_COOKIES=false ghcr.io/lagergren/rylween It pulls the latest release, starts it, and prints http://localhost:8081/login. The README also covers getting Docker or Podman with Homebrew, where `brew install docker` alone lacks the engine, and the release notes give the same command for the release's own image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A machine with only Docker or Podman and internet access can now play with one command. It needs no checkout, no git, and no JDK:
It pulls the latest release from ghcr.io and starts it. Once the server accepts connections, it prints:
Changes
/in a--usersession, which needs no login.localhost. In a container that matches the documented-p 127.0.0.1:8081:8081.RYLWEEN_PUBLIC_URLor--public-urloverrides it, for example when publishing on another port.brew install podman && podman machine init --now, orbrew install --cask docker.brew install dockeralone installs only the client, not the engine that runs containers.The published
0.9.2image already runs with this command but doesn't print the link. The next release (./gradlew releaseDist) will.Testing
Built the image from this branch with Podman and ran the README command against it:
/playloads, and/redirects to/playonce logged in.--rmremoves the container, and the data volume stays.http://localhost:<port>/loginfor a0.0.0.0bind. WithRYLWEEN_PUBLIC_URL, it prints that address instead.:runtime-bitmap-webtests pass on a forced rerun (28, none skipped), and ktlint is clean. The release workflow passes actionlint.