Repository navigation
Release by hand: the bitmap image on ghcr.io and a terminal zip, on snapshot versions and Gradle 9.9.0 - #55
Merged
Merged
Conversation
…al game as a zip rylween.version in gradle.properties is now the only place the version is set, and main carries the snapshot of the next patch release, starting with 0.9.2-SNAPSHOT. The root build fails for anything but X.Y.Z or X.Y.Z-SNAPSHOT, and the docs name no version. ./gradlew releaseDist starts the new release workflow on main, which only ever starts by hand. It refuses a version without -SNAPSHOT or one already tagged, runs the CI checks, commits and tags X.Y.Z, builds and smoke-tests the bitmap web image for linux/amd64 and linux/arm64 and the terminal game zip, pushes ghcr.io/lagergren/rylween:X.Y.Z and :latest, moves main to X.Y.(Z+1)-SNAPSHOT, and publishes the GitHub release with the zip and a compose.yaml that pulls the image. A dry run pushes and publishes nothing. setReleaseVersion and setNextSnapshotVersion make the two version moves. main takes only pull requests, so the workflow pushes with a deploy key in the RELEASE_DEPLOY_KEY secret that the main ruleset lets bypass that. The terminal zip (:runtime:terminalDistZip) ships bin/run.sh as bin/rylween, which now also runs from an unpacked download. The bitmap image's builder stage runs on the build platform, so the arm64 image needs no emulation.
The terminal game never shows the bitmap paintings, which made up 147 MB of :game's 170 MB jar. The installed launcher, and with it bin/run.sh, the scripted runtime checks, and the release zip, now runs with a copy of that jar without bitmap/**, so the zip shrinks from 180 MB to 32 MB.
Compared with Gradle 9.8.1 on a forced full run of the CI checks, the terminal zip, and the bitmap install, it gives the same warnings, no deprecations, and the same green tests. The only new task is the kotlin-dsl plugin's own :build-logic:checkKotlinCompilerVersion.
…te plugins JLine 4.5.0, Playwright 1.64.0, PMD 7.29.0, the versions plugin 0.67.0, and version-catalog-update 1.1.2. Node.js moves to 26.13.0, the current LTS line, and TypeScript to 7.0.2. TypeScript 7 no longer takes "module": "none", so the client compiles with es2020, which leaves the import-free scripts as they were, and it needs rootDir spelled out. Its DOM types widen HTMLElement.hidden to boolean | "until-found", so the three popover toggles read it through Boolean(). The generated JavaScript is otherwise unchanged. Kotlin stays on 2.4.21, the latest stable release; the update report's 2.5.0 is a beta. sarif4k and kotlin-logging come with ktlint and move with it.
Node.js 26's Linux binaries link against libatomic.so.1, which the eclipse-temurin JDK image leaves out, so npm failed with exit 127 when the image compiled the TypeScript client. The GitHub runners have it, so CI passed regardless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What a release is
One version, one tag
vX.Y.Z, and one GitHub release with:ghcr.io/lagergren/rylween:X.Y.Z(and:latest), for linux/amd64 and linux/arm64, built fromdeploy/docker/Dockerfile.bitmap-production, the same image./deploy.shbuilds.rylween-terminal-X.Y.Z.zip: unzip it and runbin/rylween(Java 25 or newer).compose.yamlthat pulls that image, so a host needs no checkout.Versions
rylween.versioningradle.propertiesis now the only place the version is set. The root build fails for anything butX.Y.ZorX.Y.Z-SNAPSHOT, and the docs no longer name a version.maincarries the next patch release's snapshot, starting at0.9.2-SNAPSHOT.Releasing
releaseDiststarts.github/workflows/release.ymlonmain. That workflow only ever starts by hand. It:-SNAPSHOT, or one already tagged,ci.ymlis now also a reusable workflow),X.Y.Zas "Release X.Y.Z" and tags it,vX.Y.Z) and the image (it must answer and logversion=X.Y.Z),X.Y.(Z+1)-SNAPSHOT, and pushes both commits tomaintogether with the tag,setReleaseVersionandsetNextSnapshotVersionmake the two version moves; they live inbuild-logic. For a minor or major release, first set the matching snapshot in a PR.Before the first release
maintakes only PRs, and the workflow's own token cannot bypass that. So the workflow pushes over SSH with a deploy key, which needs a one-time setup:Then add Deploy keys to the bypass list of the "Require PRs and CI on main" ruleset (Settings → Rules → Rulesets).
A dry run needs neither. GitHub only lets a workflow start by hand once the workflow file is on the default branch, so the first dry run can happen after this merges. After the first real release, check that the
rylweenpackage on ghcr.io is public.Also in this PR
:game's jar without the 147 MB of bitmap paintings it never shows. The zip goes from 180 MB to 32 MB."module": "none"and widenedHTMLElement.hidden, sotsconfig.jsonuseses2020with an explicitrootDir, and three popover toggles readhiddenthroughBoolean(). The generated JavaScript is otherwise identical.libatomic, which the JDK image leaves out, so the image's builder stage installs it. The GitHub runners already have it.Testing
--rerun-tasks --no-build-cache --warning-mode all) on Gradle 9.8.1, on 9.9.0, and after the dependency bumps. All green, 294 tests, none skipped. The warnings were identical across runs: only the existing JDKsun.misc.Unsafenotices. No Gradle deprecations.checkBitmapBrowserSmokepasses with Playwright 1.64 on the TypeScript 7 client.setReleaseVersionandsetNextSnapshotVersionmove the version correctly and refuse the wrong starting version. A malformed version fails the build.releaseDist: checked against a stubgh. It refuses a release version before callinggh.~/.rylween/data, and--buildis refused. ThecheckRuntime*checks and runtime tests pass against the slim launcher.compose.yaml: generated with yq as the workflow does; Compose resolves it to the pinned image.