BUG Fixes and new Feature - #39
Open
eltharynd wants to merge 7 commits into
Open
Conversation
…d plex scan update option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUG FIXES:
New Feature
I added a bool to che config to Trigger a Plex Library Update.
Why?
Lots of people have plex configured not to scan new files automatically.
This is to avoid plex displaying movies/episodes you already had as "recently added" whenever radarr/sonarr grabs a better file.
What happens then?
Currently after importing the new episodes we try updating metadata, but this results in it not finding anything on plex.
Usually what I've been doing is manually triggering plex before clicking OK.
This previously wasn't working because of #29 , so it works now, but at the same time I added the new feature to do this automatically.
How?
I added the toggle here (default to True)
When this is checked, after importing the files (before trying to update metadata) we trigger a plex library update.
NOTE: Unfortunately I could find no reliable way to subscribe to plex events to wait till the scan is over. Currently I'm just waiting 5 seconds and in my testing that's plenty when there's just a few new One Pace episodes to scan, and if it fails the app already retries after 30 seconds so that's good.
However in the future we could definitely wait for the library update in a better way altho I couldn't find one so far.