Skip to content

fix: Logic create singleton object #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gleip merged 1 commit into from
Feb 12, 2026
Merged

fix: Logic create singleton object #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions src/Container.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,10 @@ type SingletonValue = { value: Constant; init?: boolean };
class Container {
private readonly container = new Map<symbol, ContainerValue>();
private readonly singletons = new Map<symbol, SingletonValue>();
private readonly initializedKeys = new Set<symbol>();

private buildDependency(key: symbol) {
const deepDependency = this.get(key);

if (this.isAdapterDependency(deepDependency.dependency)) {
return new deepDependency.dependency.value(...deepDependency.constructor);
}

if (this.isConstantDependency(deepDependency.dependency)) {
return deepDependency.dependency.value;
}
return this.getInstance(key);
}

private inject(dependency: ContainerValue): { dependency: ContainerValue; constructor: Array<unknown> } {
Expand Down Expand Up @@ -179,11 +172,11 @@ class Container {
public async initDependencies() {
const initialized: InitializableService[] = [];
for await (const [key, dependency] of this.container) {
if (this.isAdapterDependency(dependency) && dependency.options?.init && !this.singletons.has(key)) {
if (this.isAdapterDependency(dependency) && dependency.options?.init && !this.initializedKeys.has(key)) {
const instance = this.getInstance<InitializableService>(key);
await instance?.init();
initialized.push(instance!);
this.singletons.set(key, { value: instance, init: dependency.options?.init });
this.initializedKeys.add(key);
}
}
return initialized;
Expand Down