Skip to content

Blacs error during at end of shot processing #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ispielma wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Blacs error during at end of shot processing #119

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20f290a
Abort buffered devices after post-run errors
Mar 25, 2026
54b031a
Merge branch 'labscript-suite:master' into BlacsErrorRunPost
ispielma Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions blacs/experiment_queue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,13 @@ def transition_device_to_buffered(self, name, transition_list, h5file, restart_r
@inmain_decorator(wait_for_return=True)
def get_device_error_state(self,name,device_list):
return device_list[name].error_message

def _abort_buffered_devices(self, devices_in_use, restart_function):
self.current_queue = queue.Queue()
for devicename, tab in devices_in_use.items():
if tab.mode == MODE_BUFFERED or tab.mode == MODE_TRANSITION_TO_BUFFERED:
tab.abort_buffered(self.current_queue)
inmain(tab.disconnect_restart_receiver, restart_function)


def manage(self):
Expand Down Expand Up @@ -816,12 +823,7 @@ def restart_function(device_name):
self.prepend(path)

# Need to put devices back in manual mode
self.current_queue = queue.Queue()
for devicename, tab in devices_in_use.items():
if tab.mode == MODE_BUFFERED or tab.mode == MODE_TRANSITION_TO_BUFFERED:
tab.abort_buffered(self.current_queue)
# disconnect restart signal from tabs
inmain(tab.disconnect_restart_receiver,restart_function)
self._abort_buffered_devices(devices_in_use, restart_function)
self.set_status("Error in queue manager\nQueue paused")

# disconnect and disable abort button
Expand Down Expand Up @@ -916,6 +918,7 @@ def restart_function(device_name):
error_condition = True
logger.exception("Error in queue manager execution. Queue paused.")
self.set_status("Error in queue manager\nQueue paused")
self._abort_buffered_devices(devices_in_use, restart_function)

# Raise the error in a thread for visibility
zprocess.raise_exception_in_thread(sys.exc_info())
Expand Down Expand Up @@ -997,4 +1000,3 @@ def restart_function(device_name):

self.set_status("Idle")
logger.info('Stopping')