Skip to content

refactor: standardize logger field name in engine.runtime package #541

Description

@ginccc

Background

The project convention for logger fields is LOGGER (used in 96+ files), but some older files use log or LOG. Standardizing improves grep-ability and consistency across the codebase.

How

In each file:

  1. Rename the field: private static final Logger log to private static final Logger LOGGER
  2. Replace all usages: log.info( to LOGGER.info(, log.warn( to LOGGER.warn(, etc.

Tip: IntelliJ's Rename refactoring (Shift+F6 on the field name) handles this safely per file.

Why this is safe

The field is private static final -- file-scoped with zero external references. This is a pure find-and-replace within each file.

Pattern to follow

Any file in src/main/java/ai/labs/eddi/engine/mcp/ uses the LOGGER convention.

Files to update (log -> LOGGER, 8 files)

  • src/main/java/ai/labs/eddi/engine/runtime/BoundedLogStore.java
  • src/main/java/ai/labs/eddi/engine/runtime/DatabaseLogs.java
  • src/main/java/ai/labs/eddi/engine/runtime/InstanceIdProducer.java
  • src/main/java/ai/labs/eddi/engine/runtime/ThreadContext.java
  • src/main/java/ai/labs/eddi/engine/runtime/client/configuration/ResourceClientLibrary.java
  • src/main/java/ai/labs/eddi/engine/runtime/internal/AgentFactory.java
  • src/main/java/ai/labs/eddi/engine/runtime/internal/InMemoryConversationCoordinator.java
  • src/main/java/ai/labs/eddi/engine/runtime/internal/NatsConversationCoordinator.java

Acceptance criteria

  • All 8 files use LOGGER
  • ./mvnw compile && ./mvnw test pass

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueClear scope, low risk, pattern to follow - ideal for newcomershelp wantedrefactoringCode quality improvement with no behavior changesize: SSmall: about 1 hour, 2-8 files, mechanical pattern-following

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions