This repository was archived by the owner on Apr 21, 2022. It is now read-only.
Add org.label-schema.vcs-branch and org.label-schema.vcs-tag fields to specification#22
Open
lpalgarvio wants to merge 1 commit into
Open
Add org.label-schema.vcs-branch and org.label-schema.vcs-tag fields to specification#22lpalgarvio wants to merge 1 commit into
lpalgarvio wants to merge 1 commit into
Conversation
Two schema additions: - org.label-schema.vcs-branch - org.label-schema.vcs-tag
lpalgarvio
changed the title
Contributor
|
Doesn't vcs URL + ref already uniquely identify the code? My concern would be what if the tag or branch is not consistent with the ref - which is correct? |
|
I support having both labels. |
Author
|
May this get approved and merged? |
lpalgarvio
changed the title
chamilad
approved these changes
Feb 21, 2018
chamilad
left a comment
chamilad
left a comment
There was a problem hiding this comment.
These would cover different scenarios that might benefit from clearer lookups for the branch and specific tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two schema additions: