builder: honor caller-supplied cross toolchain and PKG_CONFIG - #36
Merged
Merged
Conversation
Read TARGET_CC/TARGET_CXX/TARGET_AR/TARGET_RANLIB from the environment and override the SCons defaults when set, so external build systems (OpenWRT, Yocto, Debian rules) can cross-compile ArduLinux with their own toolchain. Resolve pkg-config via $PKG_CONFIG so libgpiod is detected against the target sysroot rather than the build host. All overrides are optional; host builds are unaffected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The v2 getLine() paths returned the result of gpiod_chip_request_lines() without checking for NULL, so a line that cannot be acquired (already held by another process or a kernel driver) surfaced later as an assertion failure in gpiod_line_request_reconfigure_lines() rather than a clear error. Mirror the v1 path: throw std::invalid_argument naming the line and chip so the caller sees "cannot acquire GPIO line N on <chip> (already in use?)". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read
TARGET_*from the environment and override the SCons defaults when set, so external build systems (OpenWRT, Yocto, Debian rules) can cross-compile ArduLinux with their own toolchain. Resolvepkg-configvia$PKG_CONFIGso libgpiod is detected against the target sysroot rather than the build host. All overrides are optional; host builds are unaffected.