docs: clarify fork-only ares fixes and correct upstream references - #31
Merged
Conversation
l50
force-pushed
the
fix/correct-ares-evidence-gate-rationale
branch
from
July 30, 2026 18:17
110d42e to
ea29c7c
Compare
l50
changed the title
**Changed:** - Updated code comments in `transport_ares.go` to use canonical `l50/ares#366` and `l50/ares#367` issue references instead of ambiguous `ares-cli` naming - Expanded `aresTokenBucket` and `uncreditableCategories` documentation to explain that the exploited-count fix and category promotions are fork-only, warning that stock `dreadnode/ares` builds will over-credit or silently stop crediting techniques - Updated test case names in `transport_ares_test.go` to match the new `l50/ares#366` and `l50/ares#367` issue references
l50
force-pushed
the
fix/correct-ares-evidence-gate-rationale
branch
from
July 30, 2026 18:34
ea29c7c to
44a3349
Compare
l50
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
Changed:
transport_ares.goandtransport_ares_test.go, replacing ambiguous "ares-cli chore(deps): update pre-commit hook codespell-project/codespell to v2.4.3 dreadnode/DreadGOAD#366"/"ares chore(deps): update terraform aws to v6.55.0 dreadnode/DreadGOAD#367" mentions with fully-qualified "fix: exclude superseded vulnerabilities from token coverage exploited count ares#366" and "fix: align tool output parsers with modern impacket and freerdp output ares#367" identifiersaresTokenBucketdoc comment to explain that the exploited-count fix relies on fork-only changes tobuild_token_coverage_jsonandstate/reader.rs, warning that stock builds lackKEY_SUPERSEDEDand will over-credit back-credited techniquesuncreditableCategoriesdocumentation to clarify the category promotion is fork-only, detailing how zerologon, nopac, and printnightmare collapse back to "other" against dreadnode/ares and cause silent crediting failures for nopac and printnightmare