fix: exempt printnightmare and zerologon from ares drift detection - #27
Closed
l50 wants to merge 1 commit into
Closed
fix: exempt printnightmare and zerologon from ares drift detection#27l50 wants to merge 1 commit into
l50 wants to merge 1 commit into
Conversation
**Added:** - Test coverage for the `nopac`, `printnightmare`, and `zerologon` first-class categories introduced in ares-cli PR dreadnode#366, ensuring uncreditable categories don't warn on every poll - `transport_ares_test.go` **Changed:** - Added `printnightmare` and `zerologon` to `driftExemptCategories` so the refusal to credit these by-design-uncreditable techniques no longer reads as mapping drift; previously they landed in the "other" catch-all and were exempt only by accident before PR dreadnode#366 promoted them to first-class categories - `transport_ares.go` - Trimmed the `driftExemptCategories` documentation for the "other" catch-all and expanded the rationale to explain the explicit `printnightmare` and `zerologon` exemptions - `transport_ares.go`
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
printnightmareandzerologonto the drift-exempt categories so they no longer surface as false-positive mapping driftAdded:
printnightmareandzerologon- Both categories are minted on evidence that precedes success (andauto_zerologonis recon-only), making them uncreditable by design; without explicit exemption their lack of technique credit was misread as mapping drift -cli/internal/scoreboard/transport_ares.gonopac,printnightmare, andzerologonas first-class ares token categories introduced in ares-cli PR chore(deps): update pre-commit hook codespell-project/codespell to v2.4.3 dreadnode/DreadGOAD#366 -cli/internal/scoreboard/transport_ares_test.goChanged:
driftExemptCategoriesdocumentation to explain the new exemptions, clarifying that these categories previously landed in theothercatch-all and were exempt only by accident before ares-cli PR chore(deps): update pre-commit hook codespell-project/codespell to v2.4.3 dreadnode/DreadGOAD#366 promoted them to first-class categories -cli/internal/scoreboard/transport_ares.go