Let the manual Claude review actually run - #193
Merged
Conversation
v0.6.17 disabled automatic review by commenting out the pull_request trigger AND setting if: false on the job. The trigger alone already did that, so the guard added nothing -- but it also applied to workflow_dispatch, which was kept. So gh workflow run started a run, skipped the job, and reported SUCCESS having reviewed nothing. A green run that did nothing is the failure this repo's tooling exists to refuse, and the one rusticprofile recorded twice about this action. Dispatch available but silently inert is worse than working or absent. Automatic review stays OFF -- only the job guard is removed; the pull_request trigger is still commented immediately above it. Assisted-By: Claude Opus 5
Assisted-By: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
v0.6.17disabled automatic Claude review by commenting out thepull_requesttrigger andsetting
if: falseon theclaude-reviewjob. The trigger alone already achieved that — but theguard also applied to
workflow_dispatch, which was kept.So
gh workflow run claude-code-review.ymlstarted a run, skipped the job, and reported successhaving reviewed nothing. A green tick, no review.
That is the exact failure this repo's tooling exists to refuse, and it is the one
rusticprofilerecorded twice about this very action — its0.0.11and0.0.14, both about areview job going green without reviewing, which is why its workflow now writes its outcome to the
step summary. "Dispatch is available but silently inert" is worse than either honest alternative:
working, or absent.
Nobody had been bitten, which is why it survived — the dispatch had never been used. Every run of
that workflow in its history is a
pull_requestevent predatingv0.6.17.Automatic review stays OFF
Only the job guard is removed. The
pull_requesttrigger remains commented immediately above it,so per-PR review is still two uncommented lines away, and this PR should show no
claude-reviewcheck. To review on demand:
The diff is one line deleted plus a comment explaining why there is deliberately no guard there —
because the next person tidying this file needs to know the omission is the point.
Found while auditing the three repos' workflows against each other, which is the same cross-repo
comparison that surfaced the nushell completion path in #191.
Type of change
How Has This Been Tested?
- if: false), verified withgit diff --numstat; theon:block is byte-unchanged, so automatic review cannot have beenre-enabled by accident.
claude-reviewcheck would appear here. It should not.
just prgreen: fmt, clippy--workspaceand--features graphics, 69 + 114 + 15 tests,man page regenerated at
retch 0.6.22, audit advisory-only.just open-pr— the recipe fixed in Make the pre-PR gate answerable; open-pr now pushes #192, dogfooding the auto-push on a branchthat had no upstream.
Not tested: that a dispatched run now completes a real review. That needs a working
CLAUDE_CODE_OAUTH_TOKEN, and the token's failure mode is exactly whatv0.6.17was reacting to.If it is still bad, the dispatch will now fail loudly instead of passing silently — which is the
point of the change, but worth saying rather than implying the review itself is verified.
Backup safety
n/a — CI configuration only.
Checklist
just manre-run after the bump and committed0.6.21→0.6.22(patch)either reviews or fails, rather than reporting success for a skipped job
Wiki not updated: §4.8's pages cover config/theming, workspace architecture, and
justrecipes/build prerequisites/the PR-merge workflow. A GitHub Actions workflow guard is none of
those.