Skip to content

Let the manual Claude review actually run - #193

Merged
l1a merged 2 commits into
mainfrom
fix/dispatchable-claude-review
Aug 13, 2026
Merged

Let the manual Claude review actually run#193
l1a merged 2 commits into
mainfrom
fix/dispatchable-claude-review

Conversation

@l1a

@l1a l1a commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Description

v0.6.17 disabled automatic Claude review by commenting out the pull_request trigger and
setting if: false on the claude-review job. The trigger alone already achieved that — but the
guard also applied to workflow_dispatch, which was kept.

So gh workflow run claude-code-review.yml started a run, skipped the job, and reported success
having reviewed nothing.
A green tick, no review.

That is the exact failure this repo's tooling exists to refuse, and it is the one
rusticprofile recorded twice about this very action — its 0.0.11 and 0.0.14, both about a
review job going green without reviewing, which is why its workflow now writes its outcome to the
step summary. "Dispatch is available but silently inert" is worse than either honest alternative:
working, or absent.

Nobody had been bitten, which is why it survived — the dispatch had never been used. Every run of
that workflow in its history is a pull_request event predating v0.6.17.

Automatic review stays OFF

Only the job guard is removed. The pull_request trigger remains commented immediately above it,
so per-PR review is still two uncommented lines away, and this PR should show no claude-review
check
. To review on demand:

gh workflow run claude-code-review.yml --ref <branch>

The diff is one line deleted plus a comment explaining why there is deliberately no guard there —
because the next person tidying this file needs to know the omission is the point.

Found while auditing the three repos' workflows against each other, which is the same cross-repo
comparison that surfaced the nushell completion path in #191.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change
  • This change requires a documentation update

How Has This Been Tested?

  • The diff is exactly one line removed (- if: false), verified with git diff --numstat; the on: block is byte-unchanged, so automatic review cannot have been
    re-enabled by accident.
  • This PR is the negative control: if the change had touched the trigger, a claude-review
    check would appear here. It should not.
  • just pr green: fmt, clippy --workspace and --features graphics, 69 + 114 + 15 tests,
    man page regenerated at retch 0.6.22, audit advisory-only.
  • Opened with just open-pr — the recipe fixed in Make the pre-PR gate answerable; open-pr now pushes #192, dogfooding the auto-push on a branch
    that had no upstream.

Not tested: that a dispatched run now completes a real review. That needs a working
CLAUDE_CODE_OAUTH_TOKEN, and the token's failure mode is exactly what v0.6.17 was reacting to.
If it is still bad, the dispatch will now fail loudly instead of passing silently — which is the
point of the change, but worth saying rather than implying the review itself is verified.

Backup safety

n/a — CI configuration only.

Checklist

  • Style, self-review, comment explaining why the guard is absent
  • Documentation updated — NOTES.md release entry
  • just man re-run after the bump and committed
  • No new warnings
  • Version bumped 0.6.210.6.22 (patch)
  • No failure mode introduced can degrade silently — this removes one; a dispatched run now
    either reviews or fails, rather than reporting success for a skipped job

Wiki not updated: §4.8's pages cover config/theming, workspace architecture, and just
recipes/build prerequisites/the PR-merge workflow. A GitHub Actions workflow guard is none of
those.

l1a added 2 commits August 12, 2026 20:33
v0.6.17 disabled automatic review by commenting out the pull_request
trigger AND setting if: false on the job. The trigger alone already did
that, so the guard added nothing -- but it also applied to
workflow_dispatch, which was kept. So gh workflow run started a run,
skipped the job, and reported SUCCESS having reviewed nothing.

A green run that did nothing is the failure this repo's tooling exists
to refuse, and the one rusticprofile recorded twice about this action.
Dispatch available but silently inert is worse than working or absent.

Automatic review stays OFF -- only the job guard is removed; the
pull_request trigger is still commented immediately above it.

Assisted-By: Claude Opus 5
Assisted-By: Claude Opus 5
@l1a
l1a merged commit e5b9b59 into main Aug 13, 2026
18 checks passed
@l1a
l1a deleted the fix/dispatchable-claude-review branch August 13, 2026 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant