Correct unreproduced exit-reconnect gap note - #57
Merged
Conversation
The v0.6.5 NOTES claimed a "clean shell exit sometimes reconnects forever" server-side gap with a specific teardown-race mechanism. A follow-up investigation could not reproduce it in 24 controlled trials (incl. a 300ms injected delay) and disproved the mechanism: pty_writer_task does not finish on PTY-EOF (the PTY feeder keeps the channel sender alive), so ctrl_writer_task is not aborted before delivering the Disconnect. Reframe the note as observed-once, unreproduced, mechanism-unconfirmed, and say not to attempt a fix without logs from a real occurrence. Wiki Troubleshooting softened to match. Assisted-By: Claude Opus 4.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Doc-only correction. PR #56's NOTES added a "Known gaps" entry claiming a server-side race where a clean remote-shell
exit"sometimes reconnects forever" instead of quitting, attributed to a specific teardown ordering bug.A follow-up investigation showed that diagnosis was wrong:
pty_writer_taskdoes not finish on PTY-EOF — the PTY feeder inhandle_connectiononly holds anArc<Mutex<Option<Sender>>>, so the channel sender stays alive until the connection ends.ctrl_writer_taskis therefore not aborted before it delivers theDisconnect; on clean shell exit the connection stays alive and the client exits cleanly.This PR reframes the note as observed-once, unreproduced, mechanism-unconfirmed, and advises capturing
etr -vvv+etrslogs from a real occurrence before attempting any fix. The wiki Troubleshooting entry is softened to match.No code changes; the earlier speculative server-side fix was not shipped.
Test plan
just prgate passes (fmt, clippy-D warnings, tests, man pages build).Notes
0.6.5(folds into the same release as Fix native-Windows input parity and terminal restore #56;v0.6.5is not yet tagged).Troubleshooting.mdupdated.