Skip to content

[STABILITY] Pass five consecutive literal full repository gates #48

Closed

Description

@kyashp

TASKS ID: STABILITY
PRD: 16 Phase 9B
Depends on all deterministic product/test rows

Acceptance:

  • run literal npm run check five consecutive times on the integrated feature-freeze SHA
  • record every run and exact counts
  • diagnose and fix any flake causally
  • no sleeps, retry inflation, worker hiding, suppression, or weakened assertions
  • pass C,I

Activity

  1. added
    bugSomething isn't working
    hackathon-readyRequired for the minimum TechJam Track 1 submission cut
    priority:P0Must complete before hackathon submission
    on Aug 30, 2026
  2. kyashp commented on Aug 30, 2026

    @kyashp
    OwnerAuthor

    Dependency: run the five consecutive gates only after deterministic feature freeze, including #41–#45 where applicable.

  3. self-assigned this
    on Aug 31, 2026
  4. sanjey99 commented on Aug 31, 2026

    @sanjey99
    Collaborator

    Ownership — STABILITY campaign

    Claiming issue #48 on branch test/48-stability-campaign, based on current origin/main. I will first reproduce and causally diagnose the two remaining recorded service.test.ts flakes, then run the literal npm run check gate five consecutive times on one immutable integrated feature-freeze SHA. Any head change restarts the counted sequence.

    Primary ownership: stability-only causal test fixes if reproduced; apps/server/src/shepherd/service.test.ts and directly implicated fixture/support code; docs/FIXES.md, docs/BUILD_LOG.md, and the STABILITY row in docs/TASKS.md after observed evidence.

    Excluded/coordination boundaries: frozen UI/theme and issue #45 independent U; issue #89 security review/posture decision; issue #65 live/model gate; unrelated product refactors, dependencies, sleeps, timeout inflation, retries, worker hiding, suppression, or weakened assertions.

    Acceptance plan: preserve RED evidence, fix only proven causes, pass targeted and adjacent checks, run literal npm run check five consecutive times with exact counts on one SHA, obtain independent review, integrate through a linked PR, and rerun on protected main before claiming C,I.

  5. sanjey99 commented on Aug 31, 2026

    @sanjey99
    Collaborator

    Draft PR #93 is open for the causal stability-fixture fixes: #93

    Candidate bd77952 remains based on origin/main@9f8579370247410a5e85df57bb4b6fe219e675b7.

    Observed before the formal campaign: general-project 9/9; F-03 5 consecutive focused runs at 2/2 each; PERF-01 5/5; attention cleanup 5/5; full server 844 passed / 3 skipped; production and test-source typechecks passed; dependency audit found 0 vulnerabilities. The normal pre-push gate then passed launcher 9/9, server 844/3 skipped, web 20/20, all typechecks, and both builds without reproducing outer-index staging.

    The literal five-consecutive-npm run check sequence and evidence-ledger commit start next. This issue remains open; integration and the updated-protected-main rerun are still pending.

  6. sanjey99 commented on Aug 31, 2026

    @sanjey99
    Collaborator

    Stability campaign reset

    The first formal sequence on candidate bd77952 is invalidated and reset to zero.

    Run Result Server evidence
    1 PASS 844 passed / 3 skipped; 143.46s
    2 PASS 844 passed / 3 skipped; 177.32s
    3 PASS 844 passed / 3 skipped; 193.55s
    4 FAIL PERF-01 timed out at 5.176s; 843 passed / 1 failed / 3 skipped

    No retry or timeout change was applied. Follow-up RED evidence showed that replacing the candidate-start polling loop with an exact promise barrier still timed out under a fresh full-suite run at 6.229s. A purpose-built autoResolution:false full-Mission variant also remained over budget at 6.038s. The Git-backed Mission lifecycle is therefore the wrong five-second harness for the scheduler-overlap contract under suite pressure.

    The revised TDD plan moves the existing production allSettledBounded primitive into the canonical scheduler module and tests the start-before-release/completion-after-release intervals directly at that exact boundary. Adjacent 30-second real-Planes tests continue to prove completed Mission, candidate selection/promotion, and promotion_completed. No timeout, retry, worker, skip, or assertion-strength change is planned.

    The candidate SHA will change. All five literal npm run check runs will restart from run 1 after the new causal fix is reviewed and committed.

  7. sanjey99 commented on Aug 31, 2026

    @sanjey99
    Collaborator

    Candidate campaign complete — integration still pending

    Draft PR #93 is updated with the completed candidate evidence: #93

    • Integrated feature-freeze base: a2a464d6be697ab949b254944b81c355a9be5403
    • Immutable five-run candidate: 10c95da098755c513a5908615313b030bd866391
    • Evidence-only final PR head: ec015b6414b56df297a83489004edae441243483

    The invalid bd77952 sequence remained reset after its fourth run exposed the full-Mission PERF-01 timing harness at 5.176s. Four causal corrections now isolate inherited Git selectors, F-03 post-cleanup observation, scheduler overlap, and candidate-cleanup preflight. No sleep, timeout/retry increase, hidden worker, suppression, skip, or weakened assertion was introduced.

    Each row below was a separate literal npm run check on the same candidate and base:

    Run Result Launcher/deploy Server Web Types/builds Warnings
    1 PASS / 0 12/12 846 passed / 3 skipped; 149.16s 20/20 4/4 / 2/2 none
    2 PASS / 0 12/12 846 passed / 3 skipped; 145.77s 20/20 4/4 / 2/2 none
    3 PASS / 0 12/12 846 passed / 3 skipped; 144.00s 20/20 4/4 / 2/2 none
    4 PASS / 0 12/12 846 passed / 3 skipped; 145.19s 20/20 4/4 / 2/2 none
    5 PASS / 0 12/12 846 passed / 3 skipped; 137.87s 20/20 4/4 / 2/2 none

    Hosted candidate runs 33351880563 and 33351880571 passed. The documentation-only final head also passed the complete local pre-push gate, then exact-head hosted runs 33353238685 (2m54s) and 33353238734 (3m43s) passed.

    Candidate gate C is passed. This issue remains open and the PR remains draft: maintainer/integrator review, protected-main merge, and a fresh gate on the resulting protected-main SHA are still required for gate I and closure.

  8. sanjey99 commented on Aug 31, 2026

    @sanjey99
    Collaborator

    Post-merge closeout ownership

    PR #93 is merged at protected-main SHA b05a4aad10d0c4c0e9f7d54fed2cdd5c779c16b0. I am taking the bounded integration-evidence closeout on branch docs/48-stability-integration-evidence from that exact SHA.

    Owned files: the STABILITY row in docs/TASKS.md, issue #48 entries TST-27–TST-30 in docs/FIXES.md, and a bounded exact-main entry in docs/BUILD_LOG.md.

    Excluded: product/test/UI code, dependencies, other ledger rows, issue #45 usability, issue #89 security, issue #65 live/model work, and all unrelated documentation.

    The exact merge has already passed one fresh literal local npm run check and hosted protected-main run 33353622211. This closeout branch will record only those observed results; it will not alter the verified behavior.

  9. sanjey99 commented on Aug 31, 2026

    @sanjey99
    Collaborator

    Protected-main gate I passed

    PR #93 merged as b05a4aad10d0c4c0e9f7d54fed2cdd5c779c16b0; its tree is byte-identical to final PR head ec015b6.

    • Fresh literal exact-main npm run check: PASS / exit 0
    • Launcher/deploy: 12/12
    • Server: 846 passed / 3 documented skips; 140.70s
    • Web: 20/20
    • Typechecks/builds: 4/4 and 2/2
    • Protected-main push workflow: 33353622211, PASS on exact b05a4aa

    Candidate gate C and integration gate I are both passed. The bounded ledger closeout is ready in PR #95: #95

    PR #95 changes only docs/BUILD_LOG.md, docs/FIXES.md, and the STABILITY row in docs/TASKS.md; its own hosted runs 33354236483 and 33354236478 passed. It contains Closes #48, so merging it will integrate the evidence and close this issue without a direct protected-main write.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workinghackathon-readyRequired for the minimum TechJam Track 1 submission cutpriority:P0Must complete before hackathon submission

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions