Repository navigation
[UI-GATE] Complete the final six-surface accessibility and visual gate #45
Description
TASKS ID: UI-GATE
PRD: 0.4, 11.1–11.7
Depends on: Project Group, denial UI, and startup-setting issues
Acceptance:
- all six surfaces plus loading, empty, error, disabled, and reconnect states
- 1280×800 and 1440×900 evidence corpus
- keyboard, focus, labels, contrast, long IDs, designated pane scrolling, zero document-level X/Y overflow
- preserve the frozen UI theme and layout
- independent read-only UI review with all High/Medium findings resolved
- pass C,B,U,I
Activity
kyashp commentedon Aug 30, 2026
Dependencies: complete #41, #43, and #44 before freezing the six-surface UI gate.
sanjey99 commentedon Aug 30, 2026
Ownership — UI-GATE audit-first candidate
Claiming issue #45 on branch \ est/45-ui-gate, based independently on current \origin/main. Final completion remains blocked by #44 and the remaining E2E rows; this branch will produce additive candidate coverage/evidence now and rerun it on the exact integrated head before any \I\ claim.
Primary ownership: a dedicated additive UI-gate Playwright spec/support module, \playwright.config.ts\ registration, and new \docs/ui-review/ui-gate/**\ evidence. Causal UI corrections are test-first and limited to findings outside another active owner's files.
Excluded/coordination boundaries: #78-owned \AgentPage.tsx, shared types, recording specs/config, and \package.json; #44 startup/settings backend; #47 auth/OPS files; #81 Contract-intake files. Shared \docs/TASKS.md\ and \docs/BUILD_LOG.md\ updates are deferred until active PR ownership clears or are coordinated explicitly.
Acceptance plan: both required viewports; six PRD surfaces; loading/empty/error/disabled/reconnect; keyboard/focus/names/roles/contrast/long IDs; designated-pane and document/body overflow; opt-in screenshots; independent read-only UI/accessibility review; \C,B,U,I, with \I\ withheld until exact-head integration.
docs(45): define the UI gate audit design
docs(45): plan the UI gate audit execution
sanjey99 commentedon Aug 30, 2026
Candidate update: draft PR #87 is at
adbb7aaon currentorigin/main0ed41dd.C: passed on exact head; hosted runs33329742709and33329742705are green.B: passed; 12/12 one-worker Chromium checks at both required viewports, with 36 exact-dimension reviewed PNGs anddocs/ui-review/ui-gate/AUDIT.md.U: independent review requested on PR test(45): add the final UI gate audit #87; no implementation-owner self-approval or manual screen-reader claim.I: pending protected-main integration, evidence regeneration, and exact integrated rerun.Local Windows Node harness remains honestly non-green at 15/19 because the four process-spawn/server cases reproduce
spawn EFTYPE; hosted Linux literalnpm run checkis the candidate gate. No live/model request ran.sanjey99 commentedon Aug 30, 2026
Post-merge status for UI-GATE:
mainascf4dd0fa5886979f2af823efa65fd028dbb03334; final candidateadbb7aais its direct second parent and the trees are identical.1280x800and1440x900.33329997913passed the literalnpm run checkjob.TASKS.md,BUILD_LOG.md, anddocs/ui-review/ui-gate/.Gates
C,B, andIare passed. Independent usability gateUremains pending, so this issue stays open and UI-GATE is not called audited.sanjey99 commentedon Aug 31, 2026
Taking over as authorized for consolidated remediation on branch fix/96-release-readiness-audit, based on current origin/main f935fdb. Primary ownership is limited to the concrete exact-main audit findings and their causal tests/evidence. No UI redesign. Issue #96 is the umbrella tracker and this issue remains linked for its own acceptance semantics. Independent review will not be self-claimed.
sanjey99 commentedon Aug 31, 2026
PR #97 now carries the deterministic UI closeout candidate. The expanded ordinary Playwright matrix passes 48/48: 24 functional flows at 1280x800 and the same 24 at 1440x900. It adds causal coverage for Agent edit hydration and rapid custom-authority toggles, Settings error recovery/reset, Agent CRUD/lifecycle/edit/delete/sorting, direct Playground, runtime-contract and malformed/missing states, accessibility names, and document overflow. The accepted design remains frozen. Independent read-only U review is still required, so this issue stays open and is not self-certified.
sanjey99 commentedon Aug 31, 2026
PR #97 is integrated as 53f2529 and the exact merge passed 48/48 functional Playwright flows (24 at each required viewport) with no document-level overflow; Web 20/20, coverage, strict types/builds, and protected-main run 33396729636 also pass. Draft PR #98 records that integration evidence. The independent read-only U review remains open and is not self-claimed.
sanjey99 commentedon Aug 31, 2026
Final independent UI acceptance is complete. A read-only auditor who did not implement the UI reviewed the integrated surface and reran the full matrix: 48/48 passed (24 at 1280×800 and 24 at 1440×900), including all six surfaces, loading/empty/error/disabled/reconnect states, keyboard/focus/labels, WCAG contrast, long IDs, designated scrolling, and zero document-level X/Y overflow. No High or Medium functional, accessibility, or visual-regression finding remains.
The accepted frozen design was preserved. Non-blocking design observations (Inter, existing shadow density, spinner convention) were intentionally left unchanged and unsuppressed under the repository UI-freeze contract. Gates C, B, U, and I are satisfied.