This repository was archived by the owner on Apr 21, 2018. It is now read-only.
Added router function for WP-Admin bar links for #3#4
Open
thoronas wants to merge 1 commit intokwight:masterfrom
Open
Added router function for WP-Admin bar links for #3#4thoronas wants to merge 1 commit intokwight:masterfrom
thoronas wants to merge 1 commit intokwight:masterfrom
Conversation
Owner
|
This is cool! It has two issues though:
It may make more sense to have page.js selectively ignore everything in the admin bar, but I'm not sure how to do that (docs mention a |
Author
|
Thanks, didn't see an easy way to do selective ignoring of links. Will play around with Good to know about the history issue, didn't think about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution for #3
Might not be most elegant solution but I don't know page.js very well. ¯_(ツ)_/¯