Skip to content
This repository was archived by the owner on Apr 21, 2018. It is now read-only.

Added router function for WP-Admin bar links for #3#4

Open
thoronas wants to merge 1 commit intokwight:masterfrom
thoronas:master
Open

Added router function for WP-Admin bar links for #3#4
thoronas wants to merge 1 commit intokwight:masterfrom
thoronas:master

Conversation

@thoronas
Copy link

Solution for #3
Might not be most elegant solution but I don't know page.js very well. ¯_(ツ)_/¯

@kwight
Copy link
Owner

kwight commented Jul 28, 2015

This is cool! It has two issues though:

  • the Logout link in the "howdy..." menu would still need to be accounted for
  • browser history breaks (clicking through to the admin and then clicking Back in the browser doesn't work)

It may make more sense to have page.js selectively ignore everything in the admin bar, but I'm not sure how to do that (docs mention a click: false option for selective binding which might help).

@thoronas
Copy link
Author

Thanks, didn't see an easy way to do selective ignoring of links. Will play around with click: false

Good to know about the history issue, didn't think about that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants