Import dividends via market-data providers; update for Wealthfolio 3.5.1#4
Open
afadil wants to merge 1 commit into
Open
Import dividends via market-data providers; update for Wealthfolio 3.5.1#4afadil wants to merge 1 commit into
afadil wants to merge 1 commit into
Conversation
…lio 3.5.1 Replace the Yahoo Finance dividend scraper with Wealthfolio's provider-neutral market data API and bring the addon up to date with Wealthfolio 3.5.x. - Fetch dividends through `market.fetchDividends`, passing symbol, exchange, instrument type, and quote currency context instead of scraping Yahoo Finance - Resolve asset metadata via `assets.getProfile` (declared under the correct `assets` permission category) - Fetch up to 5 years of dividend history using the Wealthfolio 3.5.0 default lookback - Update to addon SDK / UI / dev-tools 3.5.1 and use the SDK-native dividend types (`DividendEvent`, `FetchDividendsOptions`) - Bump to 1.1.1; require Wealthfolio 3.5.0 or newer - Refresh README with light and dark screenshots; update tests and docs Rename the dividend modules from `yahoo-dividends` to `market-dividends`.
Contributor
Author
|
The addon is now live in the store https://wealthfolio.app/addons |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the Yahoo Finance dividend scraper with Wealthfolio's provider-neutral
market data API and brings the addon up to date with Wealthfolio 3.5.x.
market.fetchDividends, passing symbol, exchange,instrument type, and quote currency context instead of scraping Yahoo Finance.
assets.getProfile, now declared under thecorrect
assetspermission category (previously grouped undermarket-data).lookback.
dividend types (
DividendEvent,FetchDividendsOptions).yahoo-dividends→market-dividends.Compatibility
Testing
pnpm type-check— passespnpm test— 69 tests across 14 files pass